🌱 Add ownerRefs to BootstrapConfig/InfraMachinePool in classy Clusters

[sbueringer]

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
Thought about this for a bit. I think it makes sense to do the same as in the MD case.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #5991

[sbueringer]

/assign @killianmuldoon

[sbueringer]

/test pull-cluster-api-e2e-full-main

[killianmuldoon]

Definitely makes sense to me.

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7e422934c38d9ee08deffa5c3534edbcbaf65136

[killianmuldoon]

/area clusterclass

[sbueringer]

/assign @chrischdi

@killianmuldoon Would it be fine to merge after Christian reviewed it as well? Or do you think we should get Fabrizio's review?

[killianmuldoon]

Or do you think we should get Fabrizio's review?

I'm not fully read into the context here - was there some decision made about this in some of the other MachinePool ClusterClass PRs?

[chrischdi]

/lgtm

[killianmuldoon]

One nice addition - I see it's already a follow-up on #5991 would be to add ownerRef validation for MachinePools in e2e.

[sbueringer]

I'm not fully read into the context here - was there some decision made about this in some of the other MachinePool ClusterClass PRs?

I intentionally didn't include it in the first PR because I wanted to think about it some more. Apart from that nobody has any MP-specific context :)

I'm basically reversing the temporary decision to diverge from MachineDeployments.

I think this could basically work the same way for MPs as for MDs. We add the Cluster as an ownerRef which means worst case the objects are getting cleaned up when the Cluster gets cleaned up.

Usually they are explicitly deleted by the MP controller during reconcileDelete. It's not perfect, but feels as good/bad as what we have for MDs

Regular cleanup for templates referenced in MDs is a lot more complicated, but I think the fallback cleanup case is here the same for MP/MD.

[fabriziopandini]

/lgtm

[killianmuldoon]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment