🐛 Fix tilt-prepare leader-elect setting #9315
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
k8s-ci-robot
added
area/devtools
| @@ -806,7 +806,7 @@ func prepareWorkload(name, prefix, binaryName, containerName string, objs []unst | |||
| debugArgs := make([]string, 0, len(args)) | |||
| for _, a := range args { | |||
| if a == "--leader-elect" || a == "--leader-elect=true" { | |||
| continue | |||
| a = "--leader-elect=false" | |||
There was a problem hiding this comment.
CAPV sets this to true which makes debugging with Tilt harder - this should fix it up.
|
/cherry-pick release-1.5 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.4 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thx! Nice fix /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e83377d1d3fd55c43b9c64410faac1ef5863ba96
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@killianmuldoon: new pull request created: #9316 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@killianmuldoon: new pull request created: #9317 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Explicitly set
--leader-electto false instead of removing it when running tilt-prepare. This helps for providers which set leader-elect to true by default./area devtools