-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Documentation improvements: suggestions for team leads #9270
Conversation
/cc @furkatgofurov7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording looks good in general- but I think this sort of information might fit better in the release team doc - that's where we have the existing time commitment info.
It would be better IMO to keep this doc as a more focused task list.
Noted will move over the text there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, few suggestions inline:
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
/approve Thank you very much for improving the docs. Leaving lgtm to folks from the release team to merge it |
@furkatgofurov7 Sort of related. We have to discuss it but I would be in favor of giving "cluster-api-release-team" reviewers and "cluster-api-relase-lead" approver rights on the docs/release folder (basically same as CHANGELOG) |
sounds like a very good idea to me |
@sbueringer sounds like a good idea to me as well |
I think we need to propose it in the next office hours, perhaps (as we always do)? |
I think it doesn't hurt and we're not in a rush. But feel free to open a PR already and cc maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Prajyot-Parab!
/lgtm
/hold
in case @killianmuldoon has further comments, feel free to unhold
LGTM label has been added. Git tree hash: af95458b938ba9383c31e5cd6159fbbe280af16a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side!
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hey, here it is: #9294 |
What this PR does / why we need it:
Part of #9216
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9216