✨ Resolve release markers

[adilGhaffarDev]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5008

/area testing

[k8s-ci-robot]

Hi @adilGhaffarDev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[furkatgofurov7]

Current CI failures should be fixed after #9275 is merged

[furkatgofurov7]

/retest

[furkatgofurov7]

@adilGhaffarDev FYI, now, CI failures are related to the changes in the PR itself, #9275 is merged and jobs went past the previous failure step.

[killianmuldoon]

/test pull-cluster-api-e2e-full-main

[killianmuldoon]

Looking good!

I think there's one edge case we want to enable - mentioned here: #5008 (comment)

Basically we need to also call the version resolution function somewhere around here:

cluster-api/test/e2e/clusterctl_upgrade.go

Line 191 in 5c4ce8b

Expect(input.E2EConfig.Variables).To(HaveKey(initWithBinaryVariableName), "Invalid argument. %s variable must be defined when calling %s spec", initWithBinaryVariableName, specName)

to ensure that it's called when INIT_WITH_BINARY is passed in as an environmental variable.

[furkatgofurov7]

Few nits, overall LGTM:

[furkatgofurov7]

cc @kubernetes-sigs/cluster-api-release-team

To make sure it is still passing

/test pull-cluster-api-e2e-full-main

[sbueringer]

Overall looks good. Nice work!

[adilGhaffarDev]

/test pull-cluster-api-e2e-full-main

[adilGhaffarDev]

@sbueringer I have addressed the comments, please check when you get time.

[sbueringer]

Thank you! One final point

[adilGhaffarDev]

/test pull-cluster-api-e2e-full-main

[sbueringer]

Thank you very much!! Really nice feature and will help us to test the latest and greatest without toil :)

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

/retest

kubeadm init failed:

[init] Using Kubernetes version: v1.23.17
[preflight] Running pre-flight checks
[preflight] Pulling images required for setting up a Kubernetes cluster
[preflight] This might take a minute or two, depending on the speed of your internet connection
[preflight] You can also perform this action in beforehand using 'kubeadm config images pull'
[certs] Using certificateDir folder "/etc/kubernetes/pki"
[certs] Using existing ca certificate authority
[certs] Generating "apiserver" certificate and key
[certs] apiserver serving cert is signed for DNS names [clusterctl-upgrade-et2f7i-hrp48-97lpc host.docker.internal kubernetes kubernetes.default kubernetes.default.svc kubernetes.default.svc.cluster.local localhost] and IPs [10.128.0.1 172.18.0.6 172.18.0.4 :: ::1 127.0.0.1 0.0.0.0]
[certs] Generating "apiserver-kubelet-client" certificate and key
[certs] Using existing front-proxy-ca certificate authority
[certs] Generating "front-proxy-client" certificate and key
[certs] Using existing etcd/ca certificate authority
[certs] Generating "etcd/server" certificate and key
[certs] etcd/server serving cert is signed for DNS names [clusterctl-upgrade-et2f7i-hrp48-97lpc localhost] and IPs [172.18.0.6 127.0.0.1 ::1]
[certs] Generating "etcd/peer" certificate and key
[certs] etcd/peer serving cert is signed for DNS names [clusterctl-upgrade-et2f7i-hrp48-97lpc localhost] and IPs [172.18.0.6 127.0.0.1 ::1]
[certs] Generating "etcd/healthcheck-client" certificate and key
[certs] Generating "apiserver-etcd-client" certificate and key
[certs] Using the existing "sa" key
[kubeconfig] Using kubeconfig folder "/etc/kubernetes"
[kubeconfig] Writing "admin.conf" kubeconfig file
[kubeconfig] Writing "kubelet.conf" kubeconfig file
[kubeconfig] Writing "controller-manager.conf" kubeconfig file
[kubeconfig] Writing "scheduler.conf" kubeconfig file
[kubelet-start] Writing kubelet environment file with flags to file "/var/lib/kubelet/kubeadm-flags.env"
[kubelet-start] Writing kubelet configuration to file "/var/lib/kubelet/config.yaml"
[kubelet-start] Starting the kubelet
[control-plane] Using manifest folder "/etc/kubernetes/manifests"
[control-plane] Creating static Pod manifest for "kube-apiserver"
[control-plane] Creating static Pod manifest for "kube-controller-manager"
[control-plane] Creating static Pod manifest for "kube-scheduler"
[etcd] Creating static Pod manifest for local etcd in "/etc/kubernetes/manifests"
[wait-control-plane] Waiting for the kubelet to boot up the control plane as static Pods from directory "/etc/kubernetes/manifests". This can take up to 4m0s
[kubelet-check] Initial timeout of 40s passed.

[chrischdi]

Found one small typo, lgtm as of that :-)

[chrischdi]

Suggested change

	// - Resolves "go://sigs.k8s.io/cluster-api@latest-v1.0" to the latest patch release of v.1.0 including rc and pre releases.
	// - Resolves "go://sigs.k8s.io/cluster-api@latest-v1.0" to the latest patch release of v1.0 including rc and pre releases.

[chrischdi]

Let's merge this to unblock #9799 .

I'll follow-up with the typo in a separate PR.

/lgtm
/hold cancel

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 062c4300d870ac831e061d142efe5c3d496ff03d

[adilGhaffarDev]

@sbueringer should I backport it too v1.6?

[sbueringer]

I think I would not backport, should be fine if folks can adopt it with v1.7. And we can run it for some time on main to see if it's stable