🌱 check resource blocking clusterctl move during discovery #9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/clusterctl
nojnhuh
force-pushed
the
block-move-discovery
branch
from
d69fa38 to
fc75cf4
Compare
|
Nice! let wait for some other clusterctl reviewer to take a look first, but overall lgtm for me |
richardcase
reviewed
Aug 29, 2023
| @@ -623,6 +623,10 @@ func waitReadyForMove(ctx context.Context, proxy Proxy, nodes []*node, dryRun bo | |||
| } | |||
|
|
|||
| for _, n := range nodes { | |||
| if !n.blockingMove { | |||
| continue | |||
There was a problem hiding this comment.
Might be helpful to have a trace level log line here, buts thats a nit.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a3c25c1d11c810e8448c7161ffc9e3d6e18eacf4
|
nojnhuh
force-pushed
the
block-move-discovery
branch
from
2716427 to
e3c78b7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a check to the discovery phase of
clusterctl moveto collect whether the resource is blocking the move with theclusterctl.cluster.x-k8s.io/block-moveannotation. This eliminates one extraneous API call during the actual move operation for all resources which already do not have the annotation.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #9196
/area clusterctl