-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 go.mod reformat to have only two require blocks #9192
🌱 go.mod reformat to have only two require blocks #9192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'd need to do this periodically if go itself doesn't keep the format consistent. Have we any way to do this or should this change be just a one off?
I think it is a one-off for now. As this is only a cosmetic optimisation I think we should not worry about it. Except there is a proper linter so we can enforce it. But I don't think its worth investing that time. |
I think it's fine as a one-off for now. Just wanted to have some order given current attention on dependencies |
/lgtm |
LGTM label has been added. Git tree hash: 488c38724cecf029d8fce27a0cfd5b03992423b7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area ci |
What this PR does / why we need it:
Follow-up after discussion at #9189 (comment)
Note: this does not add, remove or change any dependency. It only reformats the
go.mod
file.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #