Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 go.mod reformat to have only two require blocks #9192

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Follow-up after discussion at #9189 (comment)

Note: this does not add, remove or change any dependency. It only reformats the go.mod file.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd need to do this periodically if go itself doesn't keep the format consistent. Have we any way to do this or should this change be just a one off?

@chrischdi
Copy link
Member Author

I guess we'd need to do this periodically if go itself doesn't keep the format consistent. Have we any way to do this or should this change be just a one off?

I think it is a one-off for now. As this is only a cosmetic optimisation I think we should not worry about it.

Except there is a proper linter so we can enforce it. But I don't think its worth investing that time.

@sbueringer
Copy link
Member

I think it's fine as a one-off for now. Just wanted to have some order given current attention on dependencies

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 488c38724cecf029d8fce27a0cfd5b03992423b7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@chrischdi
Copy link
Member Author

/area ci

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci and removed do-not-merge/needs-area PR is missing an area label labels Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit c27d755 into kubernetes-sigs:main Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants