Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Bump to controller-runtime v0.16 #8999

Merged
merged 1 commit into from
Aug 23, 2023
Merged

⚠️ Bump to controller-runtime v0.16 #8999

merged 1 commit into from
Aug 23, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 13, 2023 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
I'll start verifying controller-runtime main on this PR.

Not really worth reviewing until we're closer to the Kubernetes / CR release (at some point towards end of August)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #8708

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2023
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot

This comment was marked as resolved.

Sign in to view
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-scale-main-experimental
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@sbueringer sbueringer changed the title [WIP] ⚠️ Bump to controller-runtime v0.16 [WIP] ⚠️ Bump to controller-runtime main / upcoming v0.16 Jul 13, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-scale-main-experimental
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2023
@sbueringer sbueringer mentioned this pull request Aug 11, 2023
Closed
13 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Aug 21, 2023 •
edited
Loading

/test pull-cluster-api-e2e-full-main

Note to myself: sort of expecting an error because of: https://github.com/kubernetes-sigs/controller-runtime/pull/2439/files#diff-7e7ff90d22397cbc25370857a4c26baa1062866c5c9581e440d1e37603e45011

EDIT: Okay not really, we are never setting Continue to a non-empty string

@sbueringer sbueringer changed the title [WIP] ⚠️ Bump to controller-runtime main / upcoming v0.16 ⚠️ Bump to controller-runtime main / upcoming v0.16 Aug 22, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@sbueringer
Copy link
Member Author

Moved the fix for kubekins/kubectl to a separate PR: #9275

This PR now depends on #9275 being merged

@sbueringer sbueringer force-pushed the pr-bump-cr-v0.16 branch 2 times, most recently from aa983bf to c4c12fa Compare August 23, 2023 07:48
furkatgofurov7
furkatgofurov7 reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5569e965f406b3046db1fab491c67c65ba34c88c

fabriziopandini
fabriziopandini reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

great work!
Nice to see how this bump went in smoothly

bootstrap/kubeadm/main.go
@@ -218,9 +220,12 @@ func main() {
LeaderElectionResourceLock: resourcelock.LeasesResourceLock,
HealthProbeBindAddress: healthAddr,
PprofBindAddress: profilerAddress,
Metrics: metricsserver.Options{
BindAddress: metricsBindAddr,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: as a follow-up, what about opening an issue for documenting how to get metrics in CAPI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR nothing changes.

Authorized metrics will be part of this effort: #9264
I was planning to write a corresponding issue and bring it up in the office hours.

But just the CR bump itself in this PR doesn't change anything

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furkatgofurov7
Copy link
Member

/retest

2 similar comments
@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/retest

@sbueringer
Bump to controller-runtime v0.16
932cdc4 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
furkatgofurov7
furkatgofurov7 reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b97670474b499d8bae1575bdda6352f6bd575034

@sbueringer
Copy link
Member Author

/hold cancel

Given all the lgtm's above

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit c074408 into kubernetes-sigs:main Aug 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 23, 2023
@sbueringer sbueringer deleted the pr-bump-cr-v0.16 branch August 23, 2023 11:36
@sbueringer sbueringer mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

@enxebre enxebre Awaiting requested review from enxebre

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@chrischdi chrischdi Awaiting requested review from chrischdi

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@chrischdi chrischdi

@enxebre enxebre

@fabriziopandini fabriziopandini

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@sbueringer @k8s-ci-robot @enxebre @killianmuldoon @furkatgofurov7 @chrischdi @fabriziopandini