🌱 cache secrets in KCP, CABPK and ClusterCacheTracker #8940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
commented
Jun 30, 2023
|
/assign @fabriziopandini @killianmuldoon @ykakarap /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test pull-cluster-api-e2e-full-main |
k8s-ci-robot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 10c873f573b2c5067a9597cdb593bd19eb3c5090
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
force-pushed
the
pr-cache-secrets
branch
from
86640be to
bde9624
Compare
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-cache-secrets
branch
from
bde9624 to
3e20833
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 062dfc2b695cccd9ea8f2f9bfb4cc69f00727471
|
|
/area provider/control-plane-kubeadm /area provider/bootstrap-kubeadm |
k8s-ci-robot
added
area/provider/control-plane-kubeadm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This PR ensures we cache secrets in KCP, CABPK and the ClusterCacheTracker (this should cover all read calls to the "ca" and kubeconfig certificates.
Based on our scale test data the uncached secret get calls take about 50% of our KCP reconcile duration and leads to a relatively high request rate to the apiserver.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #8814