🌱 Update golangci-lint to v1.53.3

[killianmuldoon]

Update golangci-lint to v1.53.2.

Release notes: https://github.com/golangci/golangci-lint/releases/tag/v1.53.2

Changes:

• Removed a return parameter from a number of functions which returned ctrl.Result where it was always nil
• Corrected assertions in a number of ginkgo Expect and Eventually calls
• Removed depguard which now requires a default config with all of the dependencies allowed or disallowed.
• Small fixup in one test using an incorrect assertion
• Enabled additional ginkgo linters

Fixes #8050

[killianmuldoon]

/area dependency

[sbueringer]

/lgtm
/approve

Let's please hold until the goofy PR is merged (I think golangci-lint is not urgent and I don't want to rebase the goofy PR more often than necessary).

/hold

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4360ca4ff7b92e7d6f14493289fa3c1bfa9807c7

[killianmuldoon]

Let's please hold until the goofy PR is merged (I think golangci-lint is not urgent and I don't want to rebase the goofy PR more often than necessary).

Sure thing - I don't think there should be too much conflict between this and that, and I can update this PR with whatever findings there might be for goofy.

[sbueringer]

Sure thing - I don't think there should be too much conflict between this and that, and I can update this PR with whatever findings there might be for goofy.

Yup. There should be ~ no overlap regarding what currently is in this PR. It's mostly about the new findings in the ~ 5,5k Go LOC in the goofy PR :)

[killianmuldoon]

/test pull-cluster-api-e2e-full-main

As this now touches a bunch of e2e code.

[killianmuldoon]

Some of these changes - e.g. fixing the asserts on ginkgo - should be cherry-picked to release 1.3 and release 1.4

[k8s-ci-robot]

@killianmuldoon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-e2e-full-main	4096b1c	link	false	/test pull-cluster-api-e2e-full-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[killianmuldoon]

/retest

[sbueringer]

/hold cancel

Should probably re-run golangci-lint now that we merged the in-memory provider. Not sure if it strictly requires a rebase onto main. Probably yes. (definitely locally if you have to fix new findings obviously :D)

[sbueringer]

Thx
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d508a2c4eb48a55ae249615ed9b578e57d8a3919

[chrischdi]

/lgtm

[fabriziopandini]

Great job!
/lgtm
/approve

[sbueringer]

/hold cancel

[sbueringer]

/hold

Sorry missed the squash

[sbueringer]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1d6366c0586cb335792d606782640c87214e4929

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/hold cancel