🌱 Download golangci-lint instead of building it #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/milestone v0.4 |
|
/assign @CecileRobertMichon |
k8s-ci-robot
added
the
size/XL
vincepri
force-pushed
the
golangci-lint-download
branch
from
83088ab to
cca009e
Compare
To reduce our go.mod/go.sum in our hack/tools folder, and to always make sure to sync golangci-lint version between our GitHub Action and our Makefile, this changeset introduces a way to download golangci-lint using their published download script. For now, we opted to copy the download script to avoid downloading it over the wire and then executing it. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
golangci-lint-download
branch
from
cca009e to
e322150
Compare
|
/assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
To reduce our go.mod/go.sum in our hack/tools folder, and to always make
sure to sync golangci-lint version between our GitHub Action and our
Makefile, this changeset introduces a way to download golangci-lint
using their published download script.
For now, we opted to copy the download script to avoid downloading it
over the wire and then executing it.