-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Refine KCP's Available, ControlPlaneComponentsHealthy, EtcdClusterHealthy v1beta2 conditions #11504
Conversation
lgtm for the changes @fabriziopandini still needs some fixup for tests |
/cherry-pick release-1.9 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…lthy v1beta2 conditions
3958f08
to
491fbcd
Compare
/lgtm |
LGTM label has been added. Git tree hash: b56ca93d1ac7a959a1f4ac17891b5d1ddfb44b7e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chrischdi: new pull request created: #11512 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Ignore machines withoout provider ID when computing KCP's Available, ControlPlaneComponentsHealthy, EtcdClusterHealthy v1beta2 conditions
/area provider/control-plane-kubeadm