-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: incorrect name used in kustomize path #11305
🐛 fix: incorrect name used in kustomize path #11305
Conversation
A kustomization file used in the test framework is using an incorrect field name after its change to kustomize v5. Specifically it was using `patch` instead of `path` which cause kustomize to fail when building. Signed-off-by: Richard Case <richard.case@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @JoelSpeed @sbueringer
LGTM label has been added. Git tree hash: 8312b363ab87483726ed0f8901cd4f45bfeb8a25
|
Thx! /approve Feel free to cherry-pick if useful |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @sbueringer 🙇 /cherrypick release-1.8 |
@richardcase: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@richardcase: new pull request created: #11307 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
A kustomization file used in the test framework is using an incorrect field name after its change to kustomize v5. Specifically it was using
patch
instead ofpath
which cause kustomize to fail when building.You would only see this if you do something like this in your tests:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area testing