Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Proposal: MachineDrainRules #11241

Merged
merged 3 commits into from
Oct 18, 2024
Merged

📖 Proposal: MachineDrainRules #11241

merged 3 commits into from
Oct 18, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11240

@sbueringer
MachineDrainRules proposal
1fb94e2 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Sep 30, 2024
@sbueringer sbueringer mentioned this pull request Sep 30, 2024
Open
8 tasks
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2024
@sbueringer
Copy link
Member Author

/assign @chrischdi @enxebre @fabriziopandini @killianmuldoon @vincepri @JoelSpeed

@sbueringer sbueringer mentioned this pull request Sep 30, 2024
Closed
@sbueringer sbueringer added the area/machine Issues or PRs related to machine lifecycle management label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Sep 30, 2024
@kreeuwijk
Copy link

Loving this solution for CAPI-11024, great work!

@sftim
Copy link
Contributor

sftim commented Oct 1, 2024

For more on the label vs. annotation thinking, see kubernetes/kubernetes#127247 (comment)

@sftim
Copy link
Contributor

sftim commented Oct 2, 2024

In general in CAPI I think we can only define annotations in our namespace.

Kubernetes is open source; anyone can propose registering an annotation (all it needs is a PR against https://kubernetes.io/docs/reference/labels-annotations-taints/)

@sbueringer
Copy link
Member Author

In general in CAPI I think we can only define annotations in our namespace.

Kubernetes is open source; anyone can propose registering an annotation (all it needs is a PR against https://kubernetes.io/docs/reference/labels-annotations-taints/)

I'm aware it's open source 😀. I assumed that these would typically be defined through KEPs

@chrischdi chrischdi mentioned this pull request Oct 4, 2024
Merged
@kreeuwijk
Copy link

I suppose using PDBs would indeed work to make the drain process wait for the pods to terminate naturally. Thanks for the tip 👍🏻

@sbueringer sbueringer force-pushed the pr-machine-drain-rules-proposal branch from 511ddd2 to aa3ea2b Compare October 8, 2024 17:28
@sbueringer
Copy link
Member Author

All findings should be addressed via aa3ea2b

PTAL :)

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c816aab3eef91dbcb5aa0b278bf841bf06e5fa66

@fabriziopandini
Copy link
Member

As per Oct 9th office hours, lazy consensus deadline set for next Friday (Oct 18th)

@enxebre
Copy link
Member

enxebre commented Oct 17, 2024

/lgtm

@sbueringer
Address review comments
f6b547f 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sbueringer sbueringer added lgtm "Looks good to me", indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Oct 18, 2024
@JoelSpeed
Copy link
Contributor

/lgtm

@fabriziopandini
Copy link
Member

Great to see we reached consensus for this first iteration!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c06a95 into kubernetes-sigs:main Oct 18, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 18, 2024
@sbueringer sbueringer deleted the pr-machine-drain-rules-proposal branch October 18, 2024 13:15
@sbueringer sbueringer mentioned this pull request Oct 30, 2024
Merged
@enxebre enxebre mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@SD-13 SD-13 Awaiting requested review from SD-13

@chrischdi chrischdi Awaiting requested review from chrischdi

@enxebre enxebre Awaiting requested review from enxebre

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@chrischdi chrischdi

@enxebre enxebre

@vincepri vincepri

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
10 participants
@sbueringer @kreeuwijk @sftim @chrischdi @fabriziopandini @k8s-ci-robot @enxebre @JoelSpeed @vincepri @killianmuldoon