Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.8] 🐛 Make KCP pre-terminate hook more robust #11164

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[release-1.8] 🐛 Make KCP pre-terminate hook more robust #11164

merged 1 commit into from
Sep 10, 2024
+31 −1

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 10, 2024 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
Manual cherry-pick of #11161

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
Make KCP pre-terminate hook more robust
bd295c4 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@sbueringer sbueringer added area/provider/control-plane-kubeadm Issues or PRs related to KCP and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-area PR is missing an area label labels Sep 10, 2024
@sbueringer
Copy link
Member Author

No conflicts, just want to speed up the test process

/assign @neolit123 @chrischdi @fabriziopandini

/hold
(so we just merge it after the PR against main merged)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-8
  • /test pull-cluster-api-e2e-blocking-release-1-8
  • /test pull-cluster-api-e2e-conformance-ci-latest-release-1-8
  • /test pull-cluster-api-e2e-conformance-release-1-8
  • /test pull-cluster-api-e2e-mink8s-release-1-8
  • /test pull-cluster-api-e2e-release-1-8
  • /test pull-cluster-api-e2e-upgrade-1-30-1-31-release-1-8
  • /test pull-cluster-api-test-mink8s-release-1-8
  • /test pull-cluster-api-test-release-1-8
  • /test pull-cluster-api-verify-release-1-8

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-8
  • pull-cluster-api-build-release-1-8
  • pull-cluster-api-e2e-blocking-release-1-8
  • pull-cluster-api-test-release-1-8
  • pull-cluster-api-verify-release-1-8

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-release-1-8
/test pull-cluster-api-e2e-conformance-release-1-8
/test pull-cluster-api-e2e-mink8s-release-1-8
/test pull-cluster-api-e2e-release-1-8
/test pull-cluster-api-e2e-upgrade-1-30-1-31-release-1-8

@sbueringer sbueringer changed the title 🐛 Make KCP pre-terminate hook more robust [release-1.8] 🐛 Make KCP pre-terminate hook more robust Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@sbueringer sbueringer mentioned this pull request Sep 10, 2024
Merged
neolit123
neolit123 reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 91c0d4dfb16d7847a9c53f61f842d0162f3b1e66

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

Flake assessment:

Also going to retest here, but if we get the same results I would merge

/retest

@sbueringer
Copy link
Member Author

/hold cancel

#11161 is merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024
@sbueringer sbueringer mentioned this pull request Sep 10, 2024
Closed
@sbueringer
Copy link
Member Author

/override pull-cluster-api-e2e-release-1-8

Test failure is unrelated

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-release-1-8

In response to this:

/override pull-cluster-api-e2e-release-1-8

Test failure is unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer sbueringer added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 945c938 into kubernetes-sigs:release-1.8 Sep 10, 2024
41 checks passed
@sbueringer sbueringer deleted the pr-make-kcp-pre-terminate-more-robust-1.8 branch September 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@neolit123 neolit123

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @k8s-ci-robot @fabriziopandini @neolit123 @chrischdi