Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Move Control Plane contracts doc to right chapter #11113

Merged
merged 1 commit into from
Sep 3, 2024
Merged

📖 Move Control Plane contracts doc to right chapter #11113

merged 1 commit into from
Sep 3, 2024

Conversation

NareshKoduru
Copy link
Contributor

Fixes #5393

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @NareshKoduru. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@NareshKoduru
Copy link
Contributor Author

cc @fabriziopandini

@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2024
fabriziopandini
fabriziopandini reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work!, only one nit

docs/book/src/SUMMARY.md Outdated Show resolved Hide resolved
@NareshKoduru
📖 Move Control Plane contracts doc to right chapter
39919b5 
add new file

Fix cluster.md path

move the line upwards
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60f48f788a368c0f07cca8e1af52b7cd0cba2367

@NareshKoduru
Copy link
Contributor Author

@fabriziopandini,
if everything looks good, could you please help with merging the pull request?Thanks

@fabriziopandini
Copy link
Member

@fabriziopandini,
if everything looks good, could you please help with merging the pull request?Thanks

Let's give a few days to other maintainers/reviewers to take a look, there is no rush for this PR

@NareshKoduru
Copy link
Contributor Author

@fabriziopandini,
if everything looks good, could you please help with merging the pull request?Thanks

Let's give a few days to other maintainers/reviewers to take a look, there is no rush for this PR

Understood. Thanks

@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit ad08926 into kubernetes-sigs:main Sep 3, 2024
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 3, 2024
@NareshKoduru NareshKoduru deleted the issue-5393 branch September 4, 2024 03:15
@fabriziopandini
Copy link
Member

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 4, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #11134

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Move Control plane provider contract documentation to the right chapter
5 participants
@NareshKoduru @k8s-ci-robot @fabriziopandini @sbueringer @k8s-infra-cherrypick-robot