Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement utils for v1beta2 conditions #10997

Merged
merged 1 commit into from
Sep 17, 2024
Merged

✨ Implement utils for v1beta2 conditions #10997

merged 1 commit into from
Sep 17, 2024

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Aug 2, 2024 •
edited
Loading

What this PR does / why we need it:
This is first iteration about implementing utils for metav1.conditions (that will be used in v1beta2 types) in Cluster API (part of #10897)

/area util

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 2, 2024
@fabriziopandini fabriziopandini mentioned this pull request Aug 2, 2024
Closed
This was referenced Aug 26, 2024
Closed
Closed
@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch from 2c54c14 to 796b0a6 Compare September 3, 2024 10:07
@fabriziopandini fabriziopandini changed the title [WIP] ✨ Implement utils for metav1 conditions [WIP] ✨ Implement utils for v1beta2 conditions Sep 9, 2024
sbueringer
sbueringer reviewed Sep 10, 2024
View reviewed changes
util/conditions/experimental/aggregate.go Outdated Show resolved Hide resolved
internal/test/builder/v1beta2_transition.go Outdated Show resolved Hide resolved
internal/test/builder/v1beta2_transition.go Show resolved Hide resolved
internal/test/builder/v1beta2_transition.go Outdated Show resolved Hide resolved
internal/test/builder/v1beta2_transition.go Outdated Show resolved Hide resolved
util/conditions/experimental/merge_strategies.go Outdated Show resolved Hide resolved
util/conditions/experimental/merge_strategies.go Outdated Show resolved Hide resolved
util/conditions/experimental/merge_strategies.go Outdated Show resolved Hide resolved
util/conditions/experimental/merge_strategies.go Outdated Show resolved Hide resolved
util/conditions/experimental/merge_strategies.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch 2 times, most recently from 7e907a1 to c88ea62 Compare September 11, 2024 19:45
@chrischdi
Copy link
Member

Maybe needs a rebase to make the linter happy

chrischdi
chrischdi reviewed Sep 12, 2024
View reviewed changes
util/conditions/v1beta2/setter.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/mirror.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/summary.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/matcher.go Show resolved Hide resolved
util/conditions/v1beta2/aggregate.go Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch from 3217411 to 949dfcf Compare September 12, 2024 10:28
@fabriziopandini fabriziopandini added tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. and removed tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. labels Sep 12, 2024
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 12, 2024
sbueringer
sbueringer reviewed Sep 12, 2024
View reviewed changes
internal/test/builder/v1beta2_transition.go Show resolved Hide resolved
util/conditions/v1beta2/options.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/aggregate.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/aggregate_test.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/aggregate_test.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/summary.go Show resolved Hide resolved
util/conditions/v1beta2/summary.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/summary.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/summary_test.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/merge_strategies.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thank you! Really really nice work! Looking forward to seeing these used in practice :)

lgtm pending the last issue around timestamps

@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch 2 times, most recently from 9c8d907 to 89ff261 Compare September 13, 2024 10:28
@fabriziopandini fabriziopandini changed the title [WIP] ✨ Implement utils for v1beta2 conditions ✨ Implement utils for v1beta2 conditions Sep 13, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@fabriziopandini
Copy link
Member Author

/hold

for #10897 to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2024
@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch from 89ff261 to 9e7ac0f Compare September 13, 2024 13:28
@sbueringer
Copy link
Member

Thx, really great work!

/lgtm
/approve

sbueringer
sbueringer reviewed Sep 17, 2024
View reviewed changes
internal/test/builder/v1beta2_transition.go Show resolved Hide resolved
util/conditions/v1beta2/mirror.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/summary.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/getter.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/getter.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/getter.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/setter_test.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/setter_test.go Show resolved Hide resolved
util/conditions/v1beta2/setter.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/setter_test.go Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed Sep 17, 2024
View reviewed changes
util/conditions/v1beta2/setter.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/setter.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch from 3cd174d to 3c0c241 Compare September 17, 2024 11:31
sbueringer
sbueringer reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very last nit from my side

util/conditions/v1beta2/getter.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch from 3c0c241 to 1a148e7 Compare September 17, 2024 13:00
@sbueringer
Copy link
Member

sbueringer commented Sep 17, 2024 •
edited
Loading

Thx!

/lgtm
/assign @chrischdi

/test pull-cluster-api-e2e-blocking-main
(let's not retry until the MP flake is green, let's just check if it's that flake and move on / merge if it is)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c05691f36d50e90259ab8cae6c519846fc900c7a

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

(triggered the wrong test above)

@fabriziopandini fabriziopandini force-pushed the experimental-condition-utils branch from 1a148e7 to 6ff3be8 Compare September 17, 2024 14:19
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@sbueringer
Copy link
Member

Thx!

/test pull-cluster-api-e2e-main

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 29ef74b828da6dcdbfda1913e35ccfc7c20104bc

@chrischdi
Copy link
Member

/approve

🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini
Copy link
Member Author

/hold cancel

#10897 merged yesterday

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

Just the MP flake, let's merge (took me 4 tries last week to get it green)

/override pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

Just the MP flake, let's merge (took me 4 tries last week to get it green)

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit b5ae1e9 into kubernetes-sigs:main Sep 17, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 17, 2024
@fabriziopandini fabriziopandini mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@chrischdi chrischdi Awaiting requested review from chrischdi

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @chrischdi @sbueringer @k8s-ci-robot