🐛 Ensure move uses mutated metadata when updating a target object #10957
Conversation
Previously, createTargetObject updated an object using the metadata (including namespace) of the unmutated object, even when the object was mutated.
k8s-ci-robot
added
kind/bug
|
Thx! /lgtm Feel free to backport further /cherry-pick release-1.8 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9ad3db1815c8708a9aee7089e63f039530652efd
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #10982 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
The
createTargetObjectfunction is called as part of the move operation. It creates the target object, i.e. the object on the target cluster. If the target object already exists, the function updates the object.Previously, the function fixed the name and namespace of the target object before it applied the experimental mutators. If some mutator modified the namespace of the target object, the function would continue to use the namespace established before the mutators were applied.
This adds a new (failing) unit test, and ensures that the target object namespace reflects the changes made by the experimental mutators.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/kind bug
/area clusterctl