Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Deprioritize unknown NodeHealthy conditions for deletion #10763

Merged
merged 1 commit into from
Jun 17, 2024
Merged

🌱 Deprioritize unknown NodeHealthy conditions for deletion #10763

merged 1 commit into from
Jun 17, 2024
+35 −9

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Follow up of #10755 (review):
For the sake of prioritization, we are not making any assumption about Health when ConditionUnknown.

/area machineset

@k8s-ci-robot k8s-ci-robot added area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2024
vincepri
vincepri approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cherry-pick release-1.7

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 363d432779bb6d9100c7692708096d977927cb98

@enxebre
Copy link
Member

enxebre commented Jun 17, 2024

@fabriziopandini it seems units needs update, lgtm otherwise

@sbueringer sbueringer mentioned this pull request Jun 17, 2024
Merged
@sbueringer sbueringer force-pushed the deprioritize-unknown-nodehalthy-for-deletion branch from de20888 to 75e07c1 Compare June 17, 2024 14:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2024
@k8s-ci-robot k8s-ci-robot requested a review from vincepri June 17, 2024 14:36
@sbueringer
Copy link
Member

@enxebre @vincepri
Reviewed & fixed (Fabrizio is not around this week)

vincepri
vincepri approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1586715b6066738766df3f828ad66c45e6762b26

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 91dd84c into kubernetes-sigs:main Jun 17, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jun 17, 2024
@sbueringer
Copy link
Member

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 17, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #10770

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini fabriziopandini deleted the deprioritize-unknown-nodehalthy-for-deletion branch June 24, 2024 11:44
@fabriziopandini fabriziopandini restored the deprioritize-unknown-nodehalthy-for-deletion branch July 2, 2024 08:35
@fabriziopandini fabriziopandini deleted the deprioritize-unknown-nodehalthy-for-deletion branch July 2, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
6 participants
@fabriziopandini @k8s-ci-robot @enxebre @sbueringer @k8s-infra-cherrypick-robot @vincepri