-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 clusterctl: ensure cert-manager objects get applied before other provider objects #10469
🐛 clusterctl: ensure cert-manager objects get applied before other provider objects #10469
Conversation
047c6ae
to
e3e6558
Compare
44e5c88
to
9cbb18b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some smaller findings
9cbb18b
to
41b9c4a
Compare
/assign @adilGhaffarDev Kindly asking for a review, because you have some context on this error case :-) |
/ok-to-test /hold for further reviews |
LGTM label has been added. Git tree hash: beb15127aa5dd6c9a70f5468e71a27fdf996ff0d
|
41b9c4a
to
8b33974
Compare
/test pull-cluster-api-e2e-main |
/cherry-pick release-1.7 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.6 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…s and wait for ca injection in tests using a clusterctl binary
8b33974
to
b239b4c
Compare
/test pull-cluster-api-e2e-main |
Thx! /lgtm |
LGTM label has been added. Git tree hash: f3b0aca96e57fe7c665ee3366c86924c9ebfb84e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/hold cancel |
@chrischdi: new pull request created: #10503 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrischdi: new pull request created: #10504 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):part of #9688
supersedes #10433
/area clusterctl