Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6] 🐛 Delete out of date machines with unhealthy control plane component conditions when rolling out KCP #10422

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[release-1.6] 🐛 Delete out of date machines with unhealthy control plane component conditions when rolling out KCP #10422

merged 1 commit into from
Apr 11, 2024

Conversation

Levi080513
Copy link
Contributor

This was manually picked from #10196 because #10196 (comment)

@Levi080513 @neolit123
@jessehu @sbueringer
🐛 Delete out of date machines with unhealthy control plane component …
d0530a6 
…conditions when rolling out KCP (#10196)

* Prioritize deletion of abnormal outdated CP machines when scaling down KCP

* Apply suggestions from code review

Co-authored-by: Lubomir I. Ivanov <neolit123@gmail.com>

* refine function comments and test code

* address review comments and refine doc

* address review comments

* fix imperfect check conditions and update ut

* add note

* redefine func name

* Update docs/proposals/20191017-kubeadm-based-control-plane.md

Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>

* Update util/collections/machine_filters.go

Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>

* rename func to UnhealthyMachinesWithMissingNodeOrUnhealthyControlPlaneComponents

* nil machine returns false

* rename func HealthyMachinesByHealthCheck to HealthyMachinesByMachineHealthCheck

* Remove !HasNode()(machine) condition from unhealthy machine filter

---------

Co-authored-by: Lubomir I. Ivanov <neolit123@gmail.com>
Co-authored-by: Jesse Hu <hui.hu@smartx.com>
Co-authored-by: Jesse Hu <jessehubj@163.com>
Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot requested review from elmiko and g-gaston April 11, 2024 12:36
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Levi080513. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Apr 11, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac1630203ae988433433d9552fc9147610f8280b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5001599 into kubernetes-sigs:release-1.6 Apr 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@g-gaston g-gaston Awaiting requested review from g-gaston

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Levi080513 @k8s-ci-robot @sbueringer