📖 Document MachinePool feature flag promotion

[nrb]

Signed-off-by: Nolan Brubaker nolan@nbrubaker.com

What this PR does / why we need it:

#10141 enabled the MachinePool feature flag by default, and this change will cause errors if providers do not update their code to reflect the change.

/area documentation

[damdo]

Thanks
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6e7c76969b544fe23e73d8ef2a95796b2e4084a4

[damdo]

cc.
@oscr @elmiko (docs)
@willie-yao @sbueringer (worked on this doc before)

[chrischdi]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

Can we get more clarity maybe on the action item for a provider maintainer/contributor?

Maybe we can link an issue or pr of a provider if available with more details about the issue?

[damdo]

@chrischdi There is an example of this in the open PR we have on the CAPA Provider:
kubernetes-sigs/cluster-api-provider-aws#4897

Here is the diff of the change

diff --git a/feature/feature.go b/feature/feature.go
index 916aebb640..061e4edd57 100644
--- a/feature/feature.go
+++ b/feature/feature.go
@@ -101,7 +101,7 @@ var defaultCAPAFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
 	EKSAllowAddRoles:              {Default: false, PreRelease: featuregate.Beta},
 	EKSFargate:                    {Default: false, PreRelease: featuregate.Alpha},
 	EventBridgeInstanceState:      {Default: false, PreRelease: featuregate.Alpha},
-	MachinePool:                   {Default: false, PreRelease: featuregate.Alpha},
+	MachinePool:                   {Default: true, PreRelease: featuregate.Beta},
 	AutoControllerIdentityCreator: {Default: true, PreRelease: featuregate.Alpha},
 	BootstrapFormatIgnition:       {Default: false, PreRelease: featuregate.Alpha},
 	ExternalResourceGC:            {Default: false, PreRelease: featuregate.Alpha},

[chrischdi]

Ah got it, prefect. Let's maybe just link this in the text as prior art, wdtyt?:

https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4897/files#diff-bd8758c39c0deb35ee6c5c387594f6575580918777fbf2926f5762c7c9fce755L104

[damdo]

Sounds good @chrischdi.
cc. @nrb

[nrb]

@chrischdi @fabriziopandini Incorporated your suggestions with the latest push.

[sbueringer]

Thx! Also thx for bringing this up!

/approve

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ffc7166c7a80c03b15c3f7aae95ddb42dde6705d

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• docs/OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

/cherry-pick release-1.6

[k8s-infra-cherrypick-robot]

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

Ooops, cherry-pick release-1.6 is not necessary, I will close it

[k8s-infra-cherrypick-robot]

@chrischdi: new pull request created: #10381

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@fabriziopandini: #10371 failed to apply on top of branch "release-1.6":

Applying: Document MachinePool feature flag promotion
Using index info to reconstruct a base tree...
A	docs/book/src/developer/providers/migrations/v1.6-to-v1.7.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): docs/book/src/developer/providers/migrations/v1.6-to-v1.7.md deleted in HEAD and modified in Document MachinePool feature flag promotion. Version Document MachinePool feature flag promotion of docs/book/src/developer/providers/migrations/v1.6-to-v1.7.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Document MachinePool feature flag promotion
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.