-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Cluster api manifesto #10329
📖 Cluster api manifesto #10329
Conversation
+1 Thanks for this, @fabriziopandini. /lgtm |
LGTM label has been added. Git tree hash: d9ce8ac3b5ad3931cc9e10a397651b3b3805baea
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found some minor nits.
+1 to have such a page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
for more folks to check maybe
LGTM label has been added. Git tree hash: 2ba8f822350fddd88ca736c0652f297deaf1dc6c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks for working on this!
/lgtm
We should backport to release-1.7 to get this in the main version of the book. /cherry-pick release-1.7 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
@killianmuldoon: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Would have been nice to give folks more than just 2-3 business days to review this PR. I think the intention from Fabrizio was to get broad community consensus on this doc (and therefore keep it open for a bit). That being said. If folks have feedback, please still comment on the PR and we'll follow-up. |
Thx for driving this! /lgtm |
I guess this should appear at https://cluster-api.sigs.k8s.io/user/manifesto or at least the first page of the book. Is there a deployment problem for the book website? (Scratch that, I saw the above comment of requiring a cherrypick.) |
/cherry-pick release-1.7 |
@AndiDog thanks for the reminder 😅 - branch should exist now |
@killianmuldoon: #10329 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Needs to be done manually |
/cherry-pick release-1.6 |
@killianmuldoon: new pull request created: #10404 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It is already in release-1.7 :-) |
What this PR does / why we need it:
Taking inspiration from Tim Hockin’s talk at KubeCon NA 2023, also for
Cluster API project is important to define the long term vision, the manifesto of “where we are going” and “why”.
/area documentation