Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 #10285

Merged
merged 1 commit into from
Mar 21, 2024
Merged

🌱 Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 #10285

merged 1 commit into from
Mar 21, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
manual bump due to linter issue in #10280

/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2024
killianmuldoon
killianmuldoon reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b501ea765c18b507711809378ad3a2c6e286481

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 20, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@fabriziopandini fabriziopandini mentioned this pull request Mar 20, 2024
Closed
@killianmuldoon killianmuldoon changed the title 🌱 Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 🌱 Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 Mar 21, 2024
killianmuldoon
killianmuldoon reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need a force push to get netlify to retyr

@killianmuldoon
Copy link
Contributor

/retest

mboersma
mboersma approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e66a6b9b547c6ef364fbc154ca1b6065937659f

@k8s-ci-robot k8s-ci-robot merged commit 7eea1d9 into kubernetes-sigs:main Mar 21, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Mar 21, 2024
@fabriziopandini fabriziopandini deleted the gomega-1.32.0 branch March 25, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@mboersma mboersma

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @k8s-ci-robot @killianmuldoon @mboersma