Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add tests and update provider_issues.go #10264

Merged
merged 1 commit into from
Mar 15, 2024
Merged

🐛 Add tests and update provider_issues.go #10264

merged 1 commit into from
Mar 15, 2024

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Mar 12, 2024 •
edited
Loading

What this PR does / why we need it:

  • This PR helps streamlines the documentation team's effort while updating providers for a new beta release.
    • We export RELEASE_TAG before running make promote-images as part of release process. I noticed that the same RELEASE_TAG cannot be used before running make release-provider-issues-tool.
    • release-provider-issues-tool expected users to export RELEASE_TAG as 1.7.0 whereas the release team initially sets RELEASE_TAG to v1.7.0-beta.0 during the release workflow.
    • Since this tool (release-provider-issues-tool) is only expected to run once every release, i.e., at the time of releasing a beta version, it is important that we streamline the RELEASE_TAG to one format to avoid any user errors.
  • I have also added supporting test cases to validate core URLs derived from RELEASE_TAG and RELEASE_DATE.
  • This PR also fixes url to CAPI v1.7.0 release timeline.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from troy0820 and yrs147 March 12, 2024 21:48
@nawazkh nawazkh marked this pull request as ready for review March 12, 2024 21:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Mar 12, 2024

/cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot
Copy link
Contributor

@nawazkh: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/cluster-api-release-team.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubernetes-sigs/cluster-api-release-team

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nawazkh
Copy link
Member Author

nawazkh commented Mar 12, 2024

Following is the expected title and body of the issue created when RELEASE_TAG=v1.7.0-beta.0 and RELEASE_DATE=2024-04-16

Issue Title:
CAPI v1.7.0-beta.0 has been released and is ready for testing

Issue body:
CAPI v1.7.0-beta.0 has been released and is ready for testing.
Looking forward to your feedback before v1.7.0 release!

For quick reference

Following are the planned dates for the upcoming releases

CAPI v1.7.0 will be released on Tuesday, 16th April 2024.

More details of the upcoming schedule can be seen at CAPI v1.7.0 release timeline.

@cahillsf
Copy link
Member

/lgtm thanks for this improvement!

@cahillsf
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7984139e5eb464e5300850eac0eac5f28f3ac42d

@nawazkh nawazkh force-pushed the update_provider_issues_tool branch from b8cace8 to 4132310 Compare March 15, 2024 06:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024
@nawazkh nawazkh force-pushed the update_provider_issues_tool branch from 4132310 to aa2df70 Compare March 15, 2024 06:27
@nawazkh nawazkh requested a review from sbueringer March 15, 2024 06:27
@sbueringer
Copy link
Member

Thx

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@cahillsf
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 665e23e713b14d89ebedf961e494d33e57d87e2b

@nawazkh
Copy link
Member Author

nawazkh commented Mar 15, 2024

/area util

@k8s-ci-robot k8s-ci-robot added area/util Issues or PRs related to utils and removed do-not-merge/needs-area PR is missing an area label labels Mar 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 55a6f44 into kubernetes-sigs:main Mar 15, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troy0820 troy0820 Awaiting requested review from troy0820

@yrs147 yrs147 Awaiting requested review from yrs147

@cahillsf cahillsf Awaiting requested review from cahillsf

@VibhorChinda VibhorChinda Awaiting requested review from VibhorChinda

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@cahillsf cahillsf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@nawazkh @k8s-ci-robot @cahillsf @sbueringer