-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 test: retry GetOwnerGraph in owner references test on certificate errors #10201
🐛 test: retry GetOwnerGraph in owner references test on certificate errors #10201
Conversation
/retitle 🌱 Wait for conversion-webhooks to be ready in clusterctl upgrade tests |
/hold Need to check a failure occurence https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/10193/pull-cluster-api-e2e-blocking-release-1-5/1762437570274267136 |
49a78c7
to
91b73e3
Compare
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel Changed to not use ListKind but Kind instead. |
/test pull-cluster-api-e2e-main |
/lgtm Feel free to unhold when you have finished validation on #10193 |
/hold |
LGTM label has been added. Git tree hash: 51c4f9b26a9ac2cc60c75e7cdbe600fac4b0db40
|
/retitle 🌱 [WIP] Wait for conversion-webhooks to be ready in clusterctl upgrade tests /hold issue still occurs in tests 🤔 |
91b73e3
to
dea02f4
Compare
/retitle 🌱 test: retry GetOwnerGraph in owner references test on certificate errors /hold issue still occurs in tests 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
/lgtm
/approve
LGTM label has been added. Git tree hash: de86e79a78fade7ddaaadef0b6c2b7beb0104a07
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/unhold |
/cherry-pick release-1.6 |
/cherry-pick release-1.5 |
/cherry-pick release-1.4 |
@chrischdi: #10201 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrischdi: #10201 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrischdi: new pull request created: #10217 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
When upgrading CAPI providers using clusterctl (as done in clusterctl upgrade tests):
ValidatingWebhookConfiguration
,MutatingWebhookConfiguration
andCRD
(for the conversion webhook)Injecting the CA into all CRDs takes some time. Our clusterctl upgrade tests immediately tries to query objects to e.g. verify that no unexpected rollouts happened.
This fails because querying objects might return from the kube-apiserver with the error
x509: certificate signed by unknown authority
when it tried to call the conversion webhook.(Because the
clusterctl upgrade
introduced a new storageVersion (v1beta1) and kube-apiserver reads objects in their stored version from etcd (e.g. v1alpha4) and converts it to v1beta1 using the conversion webhook.)The introduced code ensures that conversion webhooks work for all provider related CRDs by:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Addresses flaky tests in: #9688
Note: testing at #10193
/area e2e-testing