Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 clusterctl: move handlePlugins function call out of init to allow debugging tests #10200

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

This PR moves the call to handlePlugins() from init() to Execute().

Calling handlePlugins() at the init function leads to not being able to debug tests using dlv, instead it exits with the following error message:

Error: flags cannot be placed before plugin name: -test.run

Reason for that is that the test execution will try to run a plugin because running tests provides args. At the end it always exits with an error and os.Exit(1) here:

Moving the call to handlePlugins from the init function to Execute leads to not running it when running tests.

Found this while trying to investigate the following test:

func Test_runGetRepositories(t *testing.T) {

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area clusterctl

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2024
@chrischdi
Copy link
Member Author

Note: clusterctl plugins still work:

❯ go run ./cmd/clusterctl foo
I'm the foo plugin

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ada872b79c59a06a70db0e19932d675e534dbac

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 36a54ad into kubernetes-sigs:main Feb 29, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants