🐛 clusterctl: move handlePlugins function call out of init to allow debugging tests #10200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR moves the call to
handlePlugins()
frominit()
toExecute()
.Calling
handlePlugins()
at the init function leads to not being able to debug tests using dlv, instead it exits with the following error message:Reason for that is that the test execution will try to run a plugin because running tests provides args. At the end it always exits with an error and
os.Exit(1)
here:cluster-api/cmd/clusterctl/cmd/root.go
Line 221 in 02b8789
Moving the call to
handlePlugins
from the init function toExecute
leads to not running it when running tests.Found this while trying to investigate the following test:
cluster-api/cmd/clusterctl/cmd/config_repositories_test.go
Line 30 in 02b8789
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area clusterctl