-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [release-1.6] fix(capd): remove hack for btrfs/zfs support #10192
🐛 [release-1.6] fix(capd): remove hack for btrfs/zfs support #10192
Conversation
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps #8317 chore: PR feedback Removes the now-unused function mountDevMapper(...) chore: fix ci lint fix: restore missing storage consts chore: fix bad rebase mountDevMapper() is unused
Hi @kranurag7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we do not need this?
We have this here because kind has it too. CAPD does not really use kind
under the hood (the function linked above)🤔
I'm not sure about the content of the PR. I'm dependent on CAPD and for now I'm using an image built from main branch manually. This is supposed to be there on release-1.6 branch so that we get it in patch releases but the cherry-picking was not successful. |
Ah, I did not recognize that this is a cherry pick 👍 Please mention that in the PR comment :-) /retitle🐛 [release-1.6] fix(capd): remove hack for btrfs/zfs support This is a manual cherry pick of #8376 (comment) |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d98e510e96a7a274a227ba90b72e173d73f02d2e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area ?
@killianmuldoon: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area provider/infrastructure-docker
a516a65
into
kubernetes-sigs:release-1.6
Ref: #8376 (comment)
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves.
Helps #8317
chore: PR feedback
Removes the now-unused function mountDevMapper(...)
chore: fix ci lint
fix: restore missing storage consts
chore: fix bad rebase
mountDevMapper() is unused
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #