-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Better verbose logging on override path #10180
Conversation
Welcome @ryjogo! |
Hi @ryjogo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Change looks good to me. Could you provide a sample how the log looks like? |
Oh, sure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small cahnge for the log message, otherwise looks good and I think it provides great value when one hits the issue of override does not get used 👍
Yeah, that's more descriptive. |
Could you please rebase the PR? We should not have merge commits on the PR :-) When testing, prow automatically rebases before doing testing. |
Co-authored-by: Christian Schlotter <chrischdi@users.noreply.github.com>
Hope that did it... apologies. |
/lgtm |
LGTM label has been added. Git tree hash: f837127df0d9af9e6d79acf25eed4086987a7dbe
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Aids troubleshooting when dealing with overrides, at least it helped me when looking at #10179
/area clusterctl