-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update reference to clusterctl config file #10100
Conversation
The ProxMox initialization steps mention adding the IPAM provider to the config file. This is the first mention of the config file in the doc, with very little context as to what it is or how to work with it. This updates the text to also provide a link to the clusterctl config documentation to make it easier to find out more about what is being asked. It also updates the path given to the current XDG-based path instead of the older `$HOME/.cluster-api` directory path. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Thx! /lgtm |
/cherry-pick release-1.6 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM label has been added. Git tree hash: d1a4e9ba9cd41401e0bfc965054c275558d7f798
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #10105 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The ProxMox initialization steps mention adding the IPAM provider to the config file. This is the first mention of the config file in the doc, with very little context as to what it is or how to work with it.
This updates the text to also provide a link to the clusterctl config documentation to make it easier to find out more about what is being asked. It also updates the path given to the current XDG-based path instead of the older
$HOME/.cluster-api
directory path./area documentation