🌱 Allow using different resource group and listener name with the in memory server #10096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/infrastructure-in-memory
k8s-ci-robot
added
the
size/L
sbueringer
reviewed
Feb 6, 2024
test/infrastructure/inmemory/api/v1alpha1/inmemorycluster_types.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
sbueringer
added
the
tide/merge-method-squash
|
/approve /assign @chrischdi |
k8s-ci-robot
added
the
approved
chrischdi
reviewed
Feb 8, 2024
test/infrastructure/inmemory/api/v1alpha1/inmemorycluster_types.go
Outdated
Show resolved
Hide resolved
fabriziopandini
force-pushed
the
inmemory-decouple-resourcegroup-and-listener-name
branch
from
8a0f512 to
c05240e
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b57d6c6bcd1dd4ae76fb6e5fb5b7f9cd500ba177
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fabriziopandini
deleted the
inmemory-decouple-resourcegroup-and-listener-name
branch
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR it is now possible to use different resource group and listener name with the in-memory server.
This will greatly simplify using the in-memory server in context where the control plane endpoint and the in-memory resources are managed separately or where the name of the cluster is not known in advance, e.g. E2E tests
Note: for convenience we will continue to use the same name for resource group and listener within the in-memory, but this is not required anymore for other consumers of the in-memory server
/area provider/infrastructure-in-memory