-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ clusterctl: Add public function to create new CRD migrator #10075
✨ clusterctl: Add public function to create new CRD migrator #10075
Conversation
ef92317
to
ecdce24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area clusterctl
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
ecdce24
to
85c9fec
Compare
/lgtm Just a reminder that for everything below clusterctl
Also, worth to add that what we support is a minimal CRD migrator specifically designed according to clusterctl requirements (which are the same of the CAPI operator). Folks looking for more advanced CRD migration capabilities should look at https://github.com/kubernetes-sigs/kube-storage-version-migrator or similar projects |
LGTM label has been added. Git tree hash: c0d471b4a5053f852198a439c325765b0f628562
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add public function to create new CRD migrator, we would like to reuse the code in CAPI Operator helm chart hook to help migrate CRDs if needed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #