Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix link to v1alpha4 types #10068

Merged
merged 1 commit into from
Jan 29, 2024
Merged

🐛 Fix link to v1alpha4 types #10068

merged 1 commit into from
Jan 29, 2024

Conversation

killianmuldoon
Copy link
Contributor

Fixup a link to v1alpha4 go code in an older proposal.

/area documentations

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The label(s) area/documentations cannot be applied, because the repository doesn't have them.

In response to this:

Fixup a link to v1alpha4 go code in an older proposal.

/area documentations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jan 29, 2024
@killianmuldoon
Copy link
Contributor Author

/area documentation

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Jan 29, 2024
killianmuldoon
killianmuldoon commented Jan 29, 2024
View reviewed changes
docs/proposals/20181121-machine-api.md
@@ -41,7 +41,7 @@ performed in-place or via Node replacement.
## Proposal

This proposal introduces a new API type: Machine. See the full definition in
[machine_types.go](../../api/v1alpha4/machine_types.go).
[machine_types.go](https://github.com/kubernetes-sigs/cluster-api/blob/release-0.4/api/v1alpha4/machine_types.go).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to link to the same generation of types the proposal was talking about.

@sbueringer
Copy link
Member

Thx!

@killianmuldoon
Fix link to v1alpha4 types
ae5afb4 
Signed-off-by: killianmuldoon <cilliancapi@gmail.com>
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eb8f5ca38c213d74cf245767d8889dbf2e4bc976

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
chrischdi
chrischdi reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit e431694 into kubernetes-sigs:main Jan 29, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @k8s-ci-robot @sbueringer @chrischdi