-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Simplify testing nightly builds with clusterctl #10018
🌱 Simplify testing nightly builds with clusterctl #10018
Conversation
@@ -6,6 +6,9 @@ | |||
apiVersion: clusterctl.cluster.x-k8s.io/v1alpha3 | |||
kind: Metadata | |||
releaseSeries: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
@cahillsf Usually (1.5 & 1.6) we did this as part of "Prepare main branch for development of the new release".
Looks like we missed it for v1.7, but it also looks like it is not documented in release-tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, it is in the tasks but i missed it this time. thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I don't know what this google doc is :) (I don't have access)
Shouldn't it be documented in the publicly accessible release-tasks.md? (I didn't find it there, but maybe I missed it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I dropped the wrong link, just fixed
Add the new release to the root level metadata.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah :D
Okay somehow I missed it, but it's there
Add the new release to the root level metadata.yaml
63b19b9
to
d1c373d
Compare
d1c373d
to
f488096
Compare
Thank you! /approve /assign @chrischdi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: f9e58586e731661a55f3edff858c387eed167fd1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Provide a quick solution to test nightly builds with clusterctl
Which issue(s) this PR fixes:
Fixes #9999
/area devtools