Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Simplify testing nightly builds with clusterctl #10018

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Provide a quick solution to test nightly builds with clusterctl

Which issue(s) this PR fixes:
Fixes #9999

/area devtools

@k8s-ci-robot k8s-ci-robot added the area/devtools Issues or PRs related to devtools label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2024
@@ -6,6 +6,9 @@
apiVersion: clusterctl.cluster.x-k8s.io/v1alpha3
kind: Metadata
releaseSeries:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cahillsf Usually (1.5 & 1.6) we did this as part of "Prepare main branch for development of the new release".

Looks like we missed it for v1.7, but it also looks like it is not documented in release-tasks

Copy link
Member

@cahillsf cahillsf Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it is in the tasks but i missed it this time. thanks for fixing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I don't know what this google doc is :) (I don't have access)

Shouldn't it be documented in the publicly accessible release-tasks.md? (I didn't find it there, but maybe I missed it)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I dropped the wrong link, just fixed

Add the new release to the root level metadata.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah :D

Okay somehow I missed it, but it's there

Add the new release to the root level metadata.yaml

@fabriziopandini fabriziopandini force-pushed the simplify-testing-nightly-builds branch from 63b19b9 to d1c373d Compare January 17, 2024 17:36
@fabriziopandini fabriziopandini force-pushed the simplify-testing-nightly-builds branch from d1c373d to f488096 Compare January 17, 2024 18:48
@sbueringer
Copy link
Member

Thank you!

/approve

/assign @chrischdi

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f9e58586e731661a55f3edff858c387eed167fd1

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 8ed14d7 into kubernetes-sigs:main Jan 19, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 19, 2024
@fabriziopandini fabriziopandini deleted the simplify-testing-nightly-builds branch January 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for consuming nightly release manifests in clusterctl
5 participants