Add ObjectMeta to Docker*Templates

[randomvariable]

User Story

As per #5371, it is recommended all infrastructure providers add ObjectMeta to spec.template inside InfraMachineTemplates and InfraClusterTemplates. For completeness, this should be added to the exemplar provider, CAPD.

/kind feature
/help

[k8s-ci-robot]

@randomvariable:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

User Story

As per #5371, it is recommended all infrastructure providers add ObjectMeta to spec.template inside InfraMachineTemplates and InfraClusterTemplates. For completeness, this should be added to the exemplar provider, CAPD.

/kind feature
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[randomvariable]

/area api

[randomvariable]

/good-first-issue

[k8s-ci-robot]

@randomvariable:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

@randomvariable we need the same issue for the kubeadm types, right?

[fabriziopandini]

Is there a use case for having KubeadmConfig specific labels/annotations?

[sbueringer]

Is there a use case for having KubeadmConfig specific labels/annotations?

I'm not aware of any. But I think it would be good to have our types comply to our documentation: #5371 / #5393 (so I think either we should add ObjectMeta or not recommend ("should") it)

Let's discuss in #5371 and then potentially open issues depending on the outcome.

[randomvariable]

we need the same issue for the kubeadm types, right?

Probably, for completeness.

Is there a use case for having KubeadmConfig specific labels/annotations?

Not that I know, at least not in the same way as InfraMachines, but I think it makes sense to do since we have the logic to copy Meta in the controller.

[dharmjit]

/assign