Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation: Supported annotations and labels #5394

Closed
randomvariable opened this issue Oct 5, 2021 · 18 comments · Fixed by #7418
Closed

Missing documentation: Supported annotations and labels #5394

randomvariable opened this issue Oct 5, 2021 · 18 comments · Fixed by #7418
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@randomvariable
Copy link
Member

What steps did you take and what happened:

Have had a number of customer issues that could have been alleviated if people knew about the use of the pause annotations. The pause annotation for example is mentioned with regards to the machine health check but it has broader applicability.

In addition, when doing a code walkthrough, I stumbled across the interruptible node label, which is documented in one of the CAEPs but appears nowhere in the book with a concise summary as to why you want to use it.

/help

What did you expect to happen:

Annotations and labels are documented.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

It is probably worth having one reference document with all of the annotations and labels.

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

/help

@k8s-ci-robot
Copy link
Contributor

@randomvariable:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What steps did you take and what happened:

Have had a number of customer issues that could have been alleviated if people knew about the use of the pause annotations. The pause annotation for example is mentioned with regards to the machine health check but it has broader applicability.

In addition, when doing a code walkthrough, I stumbled across the interruptible node label, which is documented in one of the CAEPs but appears nowhere in the book with a concise summary as to why you want to use it.

/help

What did you expect to happen:

Annotations and labels are documented.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

It is probably worth having one reference document with all of the annotations and labels.

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 5, 2021
@randomvariable
Copy link
Member Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@randomvariable:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 6, 2021
@randomvariable
Copy link
Member Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 6, 2021
@chetak123
Copy link
Member

/assign @chetak123

@vincepri
Copy link
Member

/milestone v1.1

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2022
@fabriziopandini
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 25, 2022
@fabriziopandini fabriziopandini modified the milestones: v1.1, v1.2 Feb 3, 2022
@mehabhalodiya
Copy link

Hey @randomvariable
I would like to document "annotation and labels".
Will you please give me a brief idea on resolving this by providing some reference links?
Thanks.

@SubhasmitaSw
Copy link
Contributor

Hey @mehabhalodiya are you still working on it or may I pick this up?

@mehabhalodiya
Copy link

@SubhasmitaSw you can work on it.
Thanks!

@SubhasmitaSw
Copy link
Contributor

Thanks @mehabhalodiya
/assign

@killianmuldoon
Copy link
Contributor

@SubhasmitaSw have you had any time to work on this?

@killianmuldoon
Copy link
Contributor

#6966 Related - we should document spec fields and annotations together if possible.

@fabriziopandini fabriziopandini added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini fabriziopandini removed this from the v1.2 milestone Jul 29, 2022
@fabriziopandini fabriziopandini removed the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini
Copy link
Member

/triage accepted
/unassign @SubhasmitaSw

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 30, 2022
@hackeramitkumar
Copy link
Member

@fabriziopandini , I would like to work on this issue. Can you please assign it to me? And If possible show me a sample list So that I can get a basic idea.

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 12, 2022

/assign @hackeramitkumar
(I think you can assign yourself)

I will start bu adding a page in the book under reference with two paragraphs, one for supported labels and the other for supported annotations.
Each paragraph should have a table with label/annotation and note.

then you have to search in the locations listed in #5394 (comment)

for things like

// ClusterLabelName is the label set on machines linked to a cluster and
// external objects(bootstrap and infrastructure providers).
ClusterLabelName = "cluster.x-k8s.io/cluster-name"

and grab the label/annotation name + the description, something like

label note
cluster.x-k8s.io/cluster-name this label is set on machines linked to a cluster and external objects(bootstrap and infrastructure providers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants