-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing documentation: Supported annotations and labels #5394
Comments
@randomvariable: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/good-first-issue |
@randomvariable: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind documentation |
/assign @chetak123 |
/milestone v1.1 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle frozen |
Hey @randomvariable |
Hi @mehabhalodiya thanks for picking up this work!
|
Hey @mehabhalodiya are you still working on it or may I pick this up? |
@SubhasmitaSw you can work on it. |
Thanks @mehabhalodiya |
@SubhasmitaSw have you had any time to work on this? |
#6966 Related - we should document spec fields and annotations together if possible. |
/triage accepted |
@fabriziopandini , I would like to work on this issue. Can you please assign it to me? And If possible show me a sample list So that I can get a basic idea. |
/assign @hackeramitkumar I will start bu adding a page in the book under reference with two paragraphs, one for supported labels and the other for supported annotations. then you have to search in the locations listed in #5394 (comment) for things like cluster-api/api/v1beta1/common_types.go Lines 25 to 27 in bb6df67
and grab the label/annotation name + the description, something like
|
What steps did you take and what happened:
Have had a number of customer issues that could have been alleviated if people knew about the use of the pause annotations. The pause annotation for example is mentioned with regards to the machine health check but it has broader applicability.
In addition, when doing a code walkthrough, I stumbled across the
interruptible
node label, which is documented in one of the CAEPs but appears nowhere in the book with a concise summary as to why you want to use it./help
What did you expect to happen:
Annotations and labels are documented.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
It is probably worth having one reference document with all of the annotations and labels.
Environment:
kubectl version
):/etc/os-release
):/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]
/help
The text was updated successfully, but these errors were encountered: