Ensure proper handling of ErrorMessage/ErrorReason for referenced resources

[detiber]

/kind feature

Describe the solution you'd like
Ensure that we are properly checking a referenced resource for ErrorMessage/ErrorReason for referenced resources. If they are present, then we should not attempt to use data from those resources and we should propagate a summary to the user via our ErrorMessage/ErrorReason pointing the user to the resource(s) with ErrorMessage/ErrorReason set.

/priority important-soon
/milestone v1alpha2

[vincepri]

This should be already implemented as described, reconcileExternal method in cluster and machine controllers sync the errors back with the main resources.

[vincepri]

https://github.com/kubernetes-sigs/cluster-api/blob/master/controllers/machine_controller_phases.go#L156-L167

[detiber]

@vincepri looking at the linked code, it just copies the ErrorMessage/ErrorReason from the external resource, it doesn't give any additional context to the user

[vincepri]

/lifecycle active

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[detiber]

/lifecycle frozen

[vincepri]

@detiber Is this something we might want to look soon-ish or should we close it in favor of #1658 ?

[detiber]

/close
closing in favor of #1658

[k8s-ci-robot]

@detiber: Closing this issue.

In response to this:

/close
closing in favor of #1658

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.