Bump golangci-lint to v1.60.2

[sbueringer]

Let's bump golangci-lint to the latest v1.60.2 release.

Tasks:

• Bump the linter (prior art: https://github.com/kubernetes-sigs/cluster-api/pull/10398/files)
• Run make lint and fix new findings

/help

[k8s-ci-robot]

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Let's bump golangci-lint to the latest v1.60.2 release.

Tasks:

• Bump the linter (prior art: https://github.com/kubernetes-sigs/cluster-api/pull/10398/files)
• Run make lint and fix new findings

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

/triage accepted

[sbueringer]

/triage accepted

[mcbenjemaa]

huge warnings about govet printf and gosec G115

controlplane/kubeadm/internal/controllers/controller.go:505:176: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(controlPlane.KCP, controlplanev1.CertificatesAvailableCondition, controlplanev1.CertificatesGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                                             ^
controlplane/kubeadm/internal/controllers/helpers.go:201:38: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        clusterv1.ConditionSeverityError, err.Error())
                                                          ^
controlplane/kubeadm/internal/controllers/helpers.go:210:38: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        clusterv1.ConditionSeverityError, err.Error())
                                                          ^
controlplane/kubeadm/internal/controllers/helpers.go:220:39: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                clusterv1.ConditionSeverityError, err.Error())
                                                                  ^
controlplane/kubeadm/internal/controllers/remediation.go:190:161: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                conditions.MarkFalse(machineToBeRemediated, clusterv1.MachineOwnerRemediatedCondition, clusterv1.RemediationFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                                            ^
controlplane/kubeadm/internal/controllers/remediation.go:224:161: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                conditions.MarkFalse(machineToBeRemediated, clusterv1.MachineOwnerRemediatedCondition, clusterv1.RemediationFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                                            ^
controlplane/kubeadm/internal/controllers/remediation.go:229:161: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                conditions.MarkFalse(machineToBeRemediated, clusterv1.MachineOwnerRemediatedCondition, clusterv1.RemediationFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                                            ^
controlplane/kubeadm/internal/controllers/remediation.go:247:159: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(machineToBeRemediated, clusterv1.MachineOwnerRemediatedCondition, clusterv1.RemediationFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                            ^
exp/internal/controllers/machinepool_controller_phases.go:261:141: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(mp, clusterv1.InfrastructureReadyCondition, clusterv1.IncorrectExternalRefReason, clusterv1.ConditionSeverityError, fmt.Sprintf("could not find infra reference of kind %s with name %s", mp.Spec.Template.Spec.InfrastructureRef.Kind, mp.Spec.Template.Spec.InfrastructureRef.Name))
                                                                                                                                                                 ^
cmd/clusterctl/cmd/describe_cluster.go:341:60: printf: non-constant format string in call to (*github.com/fatih/color.Color).Sprintf (govet)
                name = fmt.Sprintf("%s - %s", objectPrefix, gray.Sprintf(name))
                                                                         ^
cmd/clusterctl/cmd/describe_cluster_test.go:142:56: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.UnknownCondition (govet)
                        condition:     conditions.UnknownCondition("C", "", strings.Repeat("s", 150)),
                                                                            ^
controlplane/kubeadm/internal/workload_cluster_conditions.go:446:121: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                conditions.MarkFalse(machine, staticPodCondition, controlplanev1.PodFailedReason, clusterv1.ConditionSeverityError, strings.Join(containerWaitingMessages, ", "))
                                                                                                                                                    ^
controlplane/kubeadm/internal/workload_cluster_conditions.go:451:125: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(machine, staticPodCondition, controlplanev1.PodProvisioningReason, clusterv1.ConditionSeverityInfo, strings.Join(containerWaitingMessages, ", "))
                                                                                                                                                 ^
controlplane/kubeadm/internal/workload_cluster_conditions.go:463:120: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(machine, staticPodCondition, controlplanev1.PodFailedReason, clusterv1.ConditionSeverityError, strings.Join(containerTerminatedMessages, ", "))
                                                                                                                                            ^
controlplane/kubeadm/internal/workload_cluster_conditions.go:555:122: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(input.controlPlane.KCP, input.condition, input.unhealthyReason, clusterv1.ConditionSeverityError, strings.Join(input.kcpErrors, "; "))
                                                                                                                                       ^
controlplane/kubeadm/internal/workload_cluster_conditions_test.go:1100:116: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                        expectedCondition: *conditions.FalseCondition(conditionType, unhealthyReason, clusterv1.ConditionSeverityError, fmt.Sprintf("Following machines are reporting %s errors: %s", note, "m1")),
                                                                                                                                        ^
controlplane/kubeadm/internal/workload_cluster_conditions_test.go:1115:118: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                        expectedCondition: *conditions.FalseCondition(conditionType, unhealthyReason, clusterv1.ConditionSeverityWarning, fmt.Sprintf("Following machines are reporting %s warnings: %s", note, "m1")),
                                                                                                                                          ^
controlplane/kubeadm/internal/workload_cluster_conditions_test.go:1122:115: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                        expectedCondition: *conditions.FalseCondition(conditionType, unhealthyReason, clusterv1.ConditionSeverityInfo, fmt.Sprintf("Following machines are reporting %s info: %s", note, "m1")),
                                                                                                                                       ^
controlplane/kubeadm/internal/workload_cluster_conditions_test.go:1136:82: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.UnknownCondition (govet)
                        expectedCondition: *conditions.UnknownCondition(conditionType, unknownReason, fmt.Sprintf("Following machines are reporting unknown %s status: %s", note, "m1")),
                                                                                                      ^
util/conditions/getter.go:238:102: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                        condition = FalseCondition(targetCondition, mirrorOpt.fallbackReason, mirrorOpt.fallbackSeverity, mirrorOpt.fallbackMessage)
                                                                                                                          ^
util/conditions/merge.go:79:79: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                return FalseCondition(targetCondition, targetReason, g.TopGroup().severity, targetMessage)
                                                                                            ^
util/conditions/merge.go:81:57: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.UnknownCondition (govet)
        return UnknownCondition(targetCondition, targetReason, targetMessage)
                                                               ^
exp/addons/internal/controllers/clusterresourceset_controller.go:145:151: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(clusterResourceSet, addonsv1.ResourcesAppliedCondition, addonsv1.ClusterMatchFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                    ^
exp/addons/internal/controllers/clusterresourceset_controller.go:304:150: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                conditions.MarkFalse(clusterResourceSet, addonsv1.ResourcesAppliedCondition, addonsv1.WrongSecretTypeReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                                 ^
exp/addons/internal/controllers/clusterresourceset_controller.go:306:159: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                conditions.MarkFalse(clusterResourceSet, addonsv1.ResourcesAppliedCondition, addonsv1.RetrievingResourceFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                                          ^
exp/addons/internal/controllers/clusterresourceset_controller.go:358:156: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(clusterResourceSet, addonsv1.ResourcesAppliedCondition, addonsv1.RemoteClusterClientFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                         ^
exp/addons/internal/controllers/clusterresourceset_controller.go:409:145: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(clusterResourceSet, addonsv1.ResourcesAppliedCondition, addonsv1.ApplyFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                     ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:505:166: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.CertificatesAvailableCondition, bootstrapv1.CertificatesGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                                   ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:518:162: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                               ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:524:162: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                               ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:580:157: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.CertificatesAvailableCondition, bootstrapv1.CertificatesCorruptedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                          ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:584:157: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.CertificatesAvailableCondition, bootstrapv1.CertificatesCorruptedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                          ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:630:162: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                               ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:636:162: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                               ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:643:163: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                                       ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:709:157: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.CertificatesAvailableCondition, bootstrapv1.CertificatesCorruptedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                          ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:713:157: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.CertificatesAvailableCondition, bootstrapv1.CertificatesCorruptedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                          ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:747:162: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                               ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:753:162: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                               ^
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go:760:163: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(scope.Config, bootstrapv1.DataSecretAvailableCondition, bootstrapv1.DataSecretGenerationFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                                       ^
internal/controllers/clusterclass/clusterclass_controller.go:318:5: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                                strings.Join(msg, ", "),
                                ^
internal/controllers/topology/cluster/conditions.go:70:5: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                                reconcileErr.Error(),
                                ^
internal/controllers/topology/cluster/conditions.go:103:5: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                                s.HookResponseTracker.AggregateMessage(),
                                ^
internal/controllers/topology/cluster/conditions.go:200:5: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.FalseCondition (govet)
                                msgBuilder.String(),
                                ^
internal/controllers/machine/machine_controller.go:391:136: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                        conditions.MarkFalse(m, clusterv1.DrainingSucceededCondition, clusterv1.DrainingFailedReason, clusterv1.ConditionSeverityWarning, err.Error())
                                                                                                                                                                          ^
internal/controllers/machine/machine_controller_noderef.go:152:146: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                conditions.MarkFalse(machine, clusterv1.MachineNodeHealthyCondition, clusterv1.NodeConditionsFailedReason, clusterv1.ConditionSeverityWarning, message)
                                                                                                                                                               ^
internal/controllers/machine/machine_controller_noderef.go:156:112: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkUnknown (govet)
                conditions.MarkUnknown(machine, clusterv1.MachineNodeHealthyCondition, clusterv1.NodeConditionsFailedReason, message)
                                                                                                                             ^
internal/controllers/machineset/machineset_controller.go:475:137: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(ms, clusterv1.MachinesCreatedCondition, clusterv1.PreflightCheckFailedReason, clusterv1.ConditionSeverityError, preflightCheckErrMessage)
                                                                                                                                                             ^
internal/controllers/machineset/machineset_controller.go:512:149: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                        conditions.MarkFalse(ms, clusterv1.MachinesCreatedCondition, clusterv1.BootstrapTemplateCloningFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                                       ^
internal/controllers/machineset/machineset_controller.go:542:153: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                conditions.MarkFalse(ms, clusterv1.MachinesCreatedCondition, clusterv1.InfrastructureTemplateCloningFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                                    ^
internal/controllers/machineset/machineset_controller.go:556:40: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                        clusterv1.ConditionSeverityError, err.Error())
                                                                          ^
internal/controllers/machineset/machineset_controller.go:1107:146: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                        conditions.MarkFalse(m, clusterv1.MachineOwnerRemediatedCondition, clusterv1.WaitingForRemediationReason, clusterv1.ConditionSeverityWarning, preflightCheckErrMessage)
                                                                                                                                                                      ^
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go:401:174: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                        conditions.MarkFalse(m, clusterv1.ExternalRemediationTemplateAvailableCondition, clusterv1.ExternalRemediationTemplateNotFoundReason, clusterv1.ConditionSeverityError, err.Error())
                                                                                                                                                                                                                ^
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go:430:178: printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
                                        conditions.MarkFalse(m, clusterv1.ExternalRemediationRequestAvailableCondition, clusterv1.ExternalRemediationRequestCreationFailedReason, clusterv1.ConditionSeverityError, err.Error())
                                                    

[sbueringer]

I think I would consider most of them false positives

[mcbenjemaa]

Let me try ignore them

/assign

[sbueringer]

Thx! I would say at least the ones which are calling our condition utils. I don't want to add versions of utils like conditions.MarkFalse without the vararg
(or at least I don't know what the benefit of that would be, could be I'm missing something)