Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecate metrics-bind-addr during 1.9 release cycle #10937

Closed
fabriziopandini opened this issue Jul 25, 2024 · 6 comments · Fixed by #11140
Closed

Remove the deprecate metrics-bind-addr during 1.9 release cycle #10937

fabriziopandini opened this issue Jul 25, 2024 · 6 comments · Fixed by #11140
Assignees
@Sunnatillo
Labels
area/metrics Issues or PRs related to metrics help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v1.9

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Jul 25, 2024 •
edited
Loading

Reminder for a cleanup

/kind cleanup
/area metrics
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/metrics Issues or PRs related to metrics needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2024
@fabriziopandini fabriziopandini mentioned this issue Jul 25, 2024
Merged
@sbueringer sbueringer added this to the v1.9 milestone Jul 25, 2024
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2024
@fabriziopandini fabriziopandini added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates an issue lacks a `priority/foo` label and requires one. label Jul 31, 2024
@fabriziopandini
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 31, 2024
@Sunnatillo
Copy link
Contributor

/assign

@Sunnatillo Sunnatillo mentioned this issue Oct 31, 2024
Merged
@Sunnatillo
Copy link
Contributor

/close
fixed by #11140

@k8s-ci-robot
Copy link
Contributor

@Sunnatillo: Closing this issue.

In response to this:

/close
fixed by #11140

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sunnatillo Sunnatillo

Labels
area/metrics Issues or PRs related to metrics help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

🌱 Remove previously deprecated --metrics-bind-addr flag Nordix/cluster-api
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @Sunnatillo