Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates generateUserData to fill default VMFolder if not provided. #405

Conversation

ykakarap
Copy link

@ykakarap ykakarap commented Jul 3, 2019

What this PR does / why we need it:
cloudconfig needs a valid vmFolder value. Since it is an optional field in the VsphereMachineProviderConfig (whose values are used to generate the cloudconfig) as of now we need to fill in a valid default value if not provided.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #401

Special notes for your reviewer:
The generateUserData is updated to fill in a default value for VMFolder in cloudconfig if it is not provided.
This needed a change in govmomi. vmware/govmomi#1515 makes the required changes.
The go.mod, go.sum files and the vendor folder are updated to reflect this new govmomi dependency.

FYI, looks like the vendor folder also has some changes from previous updates.

Release note:


@k8s-ci-robot
Copy link
Contributor

Welcome @ykakarap!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 3, 2019
@k8s-ci-robot k8s-ci-robot requested review from figo and sflxn July 3, 2019 22:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ykakarap
To complete the pull request process, please assign figo
You can assign the PR to them by writing /assign @figo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @ykakarap. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 3, 2019
@ykakarap
Copy link
Author

ykakarap commented Jul 3, 2019

I still need to sign the Contributor License Agreement. Having some issues with that.

@akutz
Copy link
Contributor

akutz commented Jul 3, 2019

Hi @ykakarap,

Please rebase this after running make vendor. That's how you update the project's vendored deps. It re-adds some required, non-Go assets pruned by Go modules.

@akutz
Copy link
Contributor

akutz commented Jul 3, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2019
@ykakarap ykakarap force-pushed the vmfolder-default-cloudconfig-fix branch from 1973886 to d6f3302 Compare July 3, 2019 22:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 3, 2019
@ykakarap ykakarap closed this Jul 3, 2019
@ykakarap ykakarap deleted the vmfolder-default-cloudconfig-fix branch July 3, 2019 23:22
jayunit100 pushed a commit to jayunit100/cluster-api-provider-vsphere that referenced this pull request Feb 26, 2020
Signed-off-by: Vince Prignano <vince@vincepri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-controller-manager does not start if "vmFolder" is not provided in config
3 participants