-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates generateUserData
to fill default VMFolder if not provided.
#405
Updates generateUserData
to fill default VMFolder if not provided.
#405
Conversation
Welcome @ykakarap! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ykakarap The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ykakarap. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I still need to sign the Contributor License Agreement. Having some issues with that. |
Hi @ykakarap, Please rebase this after running |
/hold |
1973886
to
d6f3302
Compare
Signed-off-by: Vince Prignano <vince@vincepri.com>
What this PR does / why we need it:
cloudconfig needs a valid
vmFolder
value. Since it is an optional field in theVsphereMachineProviderConfig
(whose values are used to generate the cloudconfig) as of now we need to fill in a valid default value if not provided.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #401
Special notes for your reviewer:
The
generateUserData
is updated to fill in a default value forVMFolder
in cloudconfig if it is not provided.This needed a change in
govmomi
. vmware/govmomi#1515 makes the required changes.The
go.mod
,go.sum
files and thevendor
folder are updated to reflect this new govmomi dependency.FYI, looks like the
vendor
folder also has some changes from previous updates.Release note: