-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 hack/tools/janitor also cleanup child resource pools and folders for capv #2870
🌱 hack/tools/janitor also cleanup child resource pools and folders for capv #2870
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2870 +/- ##
==========================================
+ Coverage 63.89% 64.01% +0.11%
==========================================
Files 160 160
Lines 9375 9367 -8
==========================================
+ Hits 5990 5996 +6
+ Misses 2923 2913 -10
+ Partials 462 458 -4 ☔ View full report in Codecov by Sentry. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits :-)
/lgtm |
LGTM label has been added. Git tree hash: 9da717e5d40e901b30c0816153d11914936bcfbc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work. I especially appreciate the extensive test coverage.
I know that code that uses govmomi has a tendency to become relatively cryptic pretty fast. Let's please try to keep it as easily readable as possible (godoc, good variable names, ...)
Thank you very much! Let's finish the discussion here: #2870 (comment) But I think we're good /lgtm /assign @fabriziopandini |
LGTM label has been added. Git tree hash: d949bdf92b4c83b52a39c7385792540a8cb2a1b6
|
/approve Great work |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds functionality to hack/tools/janitor:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #