Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add make targets to build and push vm operator image for testing purposes #2785

Merged

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Mar 1, 2024

What this PR does / why we need it:

Usage:

make release-vm-operator

Or to build and push a specific version:

VM_OPERATOR_VERSION=v1.8.1 make release-vm-operator

Outputs:

Multiarch image (linux/amd64, linux/arm64) at: https://gcr.io/k8s-staging-capi-vsphere/extra/vm-operator:v1.8.1

Manifest at: https://storage.googleapis.com/artifacts.k8s-staging-capi-vsphere.appspot.com/vm-operator/v1.8.1.yaml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2024
@k8s-ci-robot k8s-ci-robot requested review from rvanderp3 and vrabbi March 1, 2024 14:42
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2024
@chrischdi chrischdi changed the title 🌱 add make targets to build and push vm operator image for testing purposes 🌱 add make targets to build and push vm operator image for testing purposes Mar 1, 2024
Makefile Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-build-push-vm-operator branch from 665f148 to c75deed Compare March 1, 2024 15:45
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (180146b) to head (91b4212).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2785   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         160      160           
  Lines        9345     9345           
=======================================
  Hits         5982     5982           
  Misses       2906     2906           
  Partials      457      457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi chrischdi changed the title 🌱 add make targets to build and push vm operator image for testing purposes 🌱 add make targets to build and push vm operator image for testing purposes Mar 1, 2024
@fabriziopandini
Copy link
Member

fabriziopandini commented Mar 1, 2024

@chrischdi
is it possible to have a single make release-vm-operator target with build, push, and also generate the manifest + upload?

@chrischdi chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 4, 2024
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cfe825d6e7cc906db3556f9c033181971949ca10

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1caa145 into kubernetes-sigs:main Mar 4, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 4, 2024
@chrischdi chrischdi deleted the pr-build-push-vm-operator branch March 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants