-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: document tagging the test go module #2761
📖 docs: document tagging the test go module #2761
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2761 +/- ##
==========================================
+ Coverage 64.05% 64.10% +0.05%
==========================================
Files 160 160
Lines 9345 9345
==========================================
+ Hits 5986 5991 +5
+ Misses 2903 2899 -4
+ Partials 456 455 -1 ☔ View full report in Codecov by Sentry. |
/assign fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: f1d6934a450625ee3bff22756e5c5398e2200794
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.9 |
@chrischdi: new pull request created: #2881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I don't mind but just wanted to say that we don't have a book in CAPV and we also probably don't want to keep the release tasks doc up-to-date on all active release branches |
I wanted to bubble up the release tasks, because the test tag was already forgotten for the last release (v1.9.2). |
Yup good point. But don't we have the problem for all release branches. And also in general if we rely on release-tasks.md being up-to-date on all branches? (but definitely fine, this also might be a special case) |
Ack, this special case was just the release-1.9 branch did lack this information forever, and I usually copy the tag + push commands from the branch so I don't miss the test tag / leave it out :-) |
All good! If you tend to do the same for other branches, let's cherry-pick this further :) |
No need to, the module was introduced in v1.9 :-) |
What this PR does / why we need it:
We added a go module in
test
since v1.9. We also should add tags for the test module.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #