🌱 Update Cluster API IPAM version from v1alpha1 to v1beta1

[PavanNeerudu]

What this PR does / why we need it:

While working with the CAPV, I noticed that the IPAM version used is still v1alpha1. This is despite the fact that the IPAM types have been promoted to v1beta1 in the cluster-api. Additionally, the first release of the Cluster API IPAM provider in-cluster uses v1beta1, leading to an inconsistency in the versions used.

Which issue(s) this PR fixes:
Fixes #2750

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: PavanNeerudu / name: Pavan Neerudu (ca44820, bdd2890)

[k8s-ci-robot]

Welcome @PavanNeerudu!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @PavanNeerudu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

/ok-to-test

[chrischdi]

Thanks for the PR, looks straight forward :-)

Some smaller nits.

[chrischdi]

please rename this to ipamv1, maybe worth enforcing this via .golangci.yml like we already do for other apis?

[PavanNeerudu]

Yeah, sure. Added a rule to .golangci.yml as well.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.99%. Comparing base (091f636) to head (bdd2890).
Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
- Coverage   64.26%   63.99%   -0.27%     
==========================================
  Files         160      160              
  Lines        9338     9338              
==========================================
- Hits         6001     5976      -25     
- Misses       2886     2904      +18     
- Partials      451      458       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrischdi]

Maybe we need to keep the old api group for now for the test code, because in CI v1beta1 is not yet deployed (it is only used for IPAM and thus may be not up to date.

[PavanNeerudu]

Yes, makes sense. I was just looking at why the tests were failing and how the testing framework is constructed. Thanks!

[chrischdi]

/test pull-cluster-api-provider-vsphere-test-main

Unrelated flake, which gets hopefully fixed in:

• 🐛 controllers/test: use APIReader to not assert on cached information #2752

[zhanggbj]

Thanks for the PR!
/lgtm
Waiting @chrischdi for another review and approval.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ac1529614a8c8dbb414a9206f8f6dac676ac6139

[chrischdi]

Because we don't have any e2e test covering ipam: have you been able to give the implementation a try to create a cluster using IPAM?

[chrischdi]

We now have a proper test (via #2757) :-)

/test pull-cluster-api-provider-vsphere-e2e-main

[chrischdi]

Test is green 🎉

Thanks for contributing this!

/tide merge-method squash

[chrischdi]

/label tide/merge-method-squash

[chrischdi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

/retest

flake