🌱 test: run the prekubeadmscript first #2703
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/lgtm /cherry-pick release-1.9 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7c3606ef76a7de6fe85c714d71efa0bcec689356
|
k8s-ci-robot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2703 +/- ##
==========================================
+ Coverage 64.50% 64.53% +0.03%
==========================================
Files 119 119
Lines 8640 8640
==========================================
+ Hits 5573 5576 +3
+ Misses 2632 2630 -2
+ Partials 435 434 -1 ☔ View full report in Codecov by Sentry. |
|
@sbueringer: new pull request created: #2704 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
We have to run the prekubeadmscript as first so other commands which depend on the versions (e.g. kube-vip-prepare.sh) run with the correct version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #