-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Make PowerOff configurable when using vcsim #2692
🌱 Make PowerOff configurable when using vcsim #2692
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2692 +/- ##
==========================================
+ Coverage 64.47% 64.59% +0.11%
==========================================
Files 118 118
Lines 8620 8620
==========================================
+ Hits 5558 5568 +10
+ Misses 2629 2622 -7
+ Partials 433 430 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 50a7d705b8713bac47f12d4fcde860995778e6f0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How is this implemented and used? (future PR?) |
Yes, but also a fix. |
Okay got it. Was just surprised to see it as env var as it's not even configurable in the regular Cluster templates we publish (templates/* folder) |
What this PR does / why we need it:
Make PowerOff move configurable when using vcsim