Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Make PowerOff configurable when using vcsim #2692

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Make PowerOff move configurable when using vcsim

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from laozc and srm09 February 2, 2024 15:22
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25023db) 64.47% compared to head (99d0611) 64.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
+ Coverage   64.47%   64.59%   +0.11%     
==========================================
  Files         118      118              
  Lines        8620     8620              
==========================================
+ Hits         5558     5568      +10     
+ Misses       2629     2622       -7     
+ Partials      433      430       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 50a7d705b8713bac47f12d4fcde860995778e6f0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8e15d16 into kubernetes-sigs:main Feb 2, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 2, 2024
@fabriziopandini fabriziopandini changed the title 🌱 Make PowerOff move configurable when using vcsim 🌱 Make PowerOff configurable when using vcsim Feb 2, 2024
@sbueringer
Copy link
Member

How is this implemented and used? (future PR?)

@fabriziopandini
Copy link
Member Author

How is this implemented and used? (future PR?)

Yes, but also a fix.
PowerOff mode was the only remaining hard-coded value in the list of settings that are included in the list of EnvVar and then used by templates, in this case for the upcoming tests for supervisor mode.

@sbueringer
Copy link
Member

Okay got it. Was just surprised to see it as env var as it's not even configurable in the regular Cluster templates we publish (templates/* folder)

@fabriziopandini fabriziopandini deleted the make-vcsim-PowerOffMode-configurable branch February 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants