🌱 e2e: only upload images to gcs if we run tests which need it

[chrischdi]

What this PR does / why we need it:

Only uploads the docker image to gcs when we don't set GINKGO_FOCUS.

We set GINKGO_FOCUS at all e2e periodics + presubmits except for the {periodic,pull}-cluster-api-provider-vsphere-e2e which are the only ones where we require to upload the images because of running the clusterctl upgrade tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[chrischdi]

/test help

[k8s-ci-robot]

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-vsphere-e2e-blocking-main
• /test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main
• /test pull-cluster-api-provider-vsphere-e2e-conformance-main
• /test pull-cluster-api-provider-vsphere-e2e-main
• /test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main
• /test pull-cluster-api-provider-vsphere-test-integration-main
• /test pull-cluster-api-provider-vsphere-test-main
• /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-vsphere-apidiff-main
• pull-cluster-api-provider-vsphere-e2e-blocking-main
• pull-cluster-api-provider-vsphere-test-integration-main
• pull-cluster-api-provider-vsphere-test-main
• pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-conformance-main

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-main

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

[chrischdi]

/cherry-pick release-1.9

[k8s-infra-cherrypick-robot]

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (187cd63) 64.54% compared to head (ff8b233) 64.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2686      +/-   ##
==========================================
+ Coverage   64.54%   64.66%   +0.11%     
==========================================
  Files         118      118              
  Lines        8620     8620              
==========================================
+ Hits         5564     5574      +10     
+ Misses       2625     2618       -7     
+ Partials      431      428       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sbueringer]

/lgtm
/approve

(I also checked the e2e test logs)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 55892218ba1546e874df7b2166d0654cece875f0

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

conformance test failures are expected

/override pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

[k8s-ci-robot]

@chrischdi: Overrode contexts on behalf of chrischdi: pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

In response to this:

conformance test failures are expected

/override pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@chrischdi: #2686 failed to apply on top of branch "release-1.9":

Applying: e2e: only upload images to gcs if we run tests which need it
Using index info to reconstruct a base tree...
M	hack/e2e.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/e2e.sh
CONFLICT (content): Merge conflict in hack/e2e.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 e2e: only upload images to gcs if we run tests which need it
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.