-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 vspherevm: ensure that the cache gets updated when patching .status.taskRef #2677
🐛 vspherevm: ensure that the cache gets updated when patching .status.taskRef #2677
Conversation
/assign sbueringer |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
==========================================
- Coverage 64.70% 64.66% -0.04%
==========================================
Files 118 118
Lines 8580 8593 +13
==========================================
+ Hits 5552 5557 +5
- Misses 2597 2604 +7
- Partials 431 432 +1 ☔ View full report in Codecov by Sentry. |
9c084ed
to
b1e7673
Compare
/test pull-cluster-api-provider-vsphere-e2e-main |
b1e7673
to
22bb16e
Compare
/test pull-cluster-api-provider-vsphere-e2e-main |
Thx! /lgtm |
LGTM label has been added. Git tree hash: 7993113a00192c54ba542f6b1ca58deac309866b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherry-pick release-1.9 |
@chrischdi: new pull request created: #2680 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
A vSphereVM could reconcile again with using an outdated object from the cache.
In case of a VSphereVM which get's deleted this could lead to triggering a task to destroy the VM twice. While the second one would fail after some timeout.
Did hit this issue at https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/2594/pull-cluster-api-provider-vsphere-e2e-main/1752293260056858624
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #