🌱 Add unit test cases for clustermodule #2436

MrDXY · 2023-10-16T04:43:37Z

What this PR does / why we need it:

Add unit test cases for pkg/clustermodule/service.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2308

k8s-ci-robot · 2023-10-16T04:43:47Z

Hi @MrDXY. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhanggbj · 2023-10-16T05:36:07Z

/ok-to-test

codecov · 2023-10-16T05:44:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5211b8e) 62.83% compared to head (464bf58) 63.85%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
+ Coverage   62.83%   63.85%   +1.02%     
==========================================
  Files         122      122              
  Lines        8763     8763              
==========================================
+ Hits         5506     5596      +90     
+ Misses       2863     2763     -100     
- Partials      394      404      +10

Files	Coverage Δ
test/helpers/vcsim/builder.go	`85.10% <ø> (ø)`

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/session/fake/fake_session.go

Makefile

pkg/clustermodule/service_test.go

chrischdi

NIce work with using vcims. This gets very clean :-)

pkg/clustermodule/service_test.go

MrDXY · 2023-10-20T02:14:21Z

/retest

MrDXY · 2023-10-24T02:17:06Z

Hi @chrischdi , This PR is ready for another round of review; please feel free to take a look whenever you get a chance. 😄

pkg/clustermodule/service_test.go

chrischdi · 2023-10-24T06:12:14Z

Hi @chrischdi , This PR is ready for another round of review; please feel free to take a look whenever you get a chance. 😄

Sorry for the late reply, forgot to send out the above comment 🤦

MrDXY · 2023-10-25T01:27:59Z

Sorry for the late reply, forgot to send out the above comment 🤦

No problem at all. I'll take care of this. 😄

MrDXY · 2023-10-25T01:45:48Z

/retest

chrischdi

Last nit

/lgtm

pkg/clustermodule/service_test.go

k8s-ci-robot · 2023-10-25T14:56:32Z

LGTM label has been added.

Git tree hash: fc6407caf80ab6a9d78c85c1c74ada07a6a35d48

chrischdi

/approve

killianmuldoon

/lgtm
/approve

Thanks!

k8s-ci-robot · 2023-10-26T17:23:27Z

LGTM label has been added.

Git tree hash: d4a3e20dd2f796f4b6aabd06606907c5a99f21df

k8s-ci-robot · 2023-10-26T17:23:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chrischdi,killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chrischdi

REMOVED (posted at the wrong PR)

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2023

k8s-ci-robot requested review from gab-satchi and zhanggbj October 16, 2023 04:43

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2023

zhanggbj reviewed Oct 16, 2023

View reviewed changes

pkg/session/fake/fake_session.go Outdated Show resolved Hide resolved

pkg/session/fake/fake_session.go Outdated Show resolved Hide resolved

pkg/session/fake/fake_session.go Outdated Show resolved Hide resolved

chrischdi reviewed Oct 16, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

pkg/clustermodule/service_test.go Outdated Show resolved Hide resolved

chrischdi reviewed Oct 16, 2023

View reviewed changes

pkg/clustermodule/service_test.go Outdated Show resolved Hide resolved

MrDXY force-pushed the pr_unit_test_for_clustermodule branch 3 times, most recently from 08da419 to 2502c47 Compare October 18, 2023 06:09

chrischdi reviewed Oct 19, 2023

View reviewed changes

pkg/clustermodule/service_test.go Outdated Show resolved Hide resolved

pkg/clustermodule/service_test.go Outdated Show resolved Hide resolved

pkg/clustermodule/service_test.go Outdated Show resolved Hide resolved

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2023

MrDXY force-pushed the pr_unit_test_for_clustermodule branch from fbb2ee3 to 9301b5d Compare October 20, 2023 02:01

chrischdi reviewed Oct 24, 2023

View reviewed changes

pkg/clustermodule/service_test.go Outdated Show resolved Hide resolved

MrDXY force-pushed the pr_unit_test_for_clustermodule branch 2 times, most recently from 1759ccb to 2abca7b Compare October 25, 2023 01:42

chrischdi reviewed Oct 25, 2023

View reviewed changes

pkg/clustermodule/service_test.go Outdated Show resolved Hide resolved

k8s-ci-robot assigned chrischdi Oct 25, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2023

MrDXY force-pushed the pr_unit_test_for_clustermodule branch from 2abca7b to 5a0e470 Compare October 26, 2023 01:15

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023

k8s-ci-robot requested a review from chrischdi October 26, 2023 01:15

MrDXY force-pushed the pr_unit_test_for_clustermodule branch from 5a0e470 to fea7f05 Compare October 26, 2023 01:36

Add unit test cases for ClusterModule

464bf58

MrDXY force-pushed the pr_unit_test_for_clustermodule branch from fea7f05 to 464bf58 Compare October 26, 2023 01:42

chrischdi reviewed Oct 26, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023

killianmuldoon reviewed Oct 26, 2023

View reviewed changes

k8s-ci-robot assigned killianmuldoon Oct 26, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023

k8s-ci-robot merged commit a4eef1b into kubernetes-sigs:main Oct 26, 2023
10 checks passed

k8s-ci-robot added this to the v1.9 milestone Oct 26, 2023

chrischdi reviewed Oct 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 Add unit test cases for clustermodule #2436

🌱 Add unit test cases for clustermodule #2436

MrDXY commented Oct 16, 2023

k8s-ci-robot commented Oct 16, 2023

zhanggbj commented Oct 16, 2023

codecov bot commented Oct 16, 2023 •

edited

Loading

chrischdi left a comment

MrDXY commented Oct 20, 2023

MrDXY commented Oct 24, 2023

chrischdi commented Oct 24, 2023

MrDXY commented Oct 25, 2023

MrDXY commented Oct 25, 2023

chrischdi left a comment

k8s-ci-robot commented Oct 25, 2023

chrischdi left a comment

killianmuldoon left a comment

k8s-ci-robot commented Oct 26, 2023

k8s-ci-robot commented Oct 26, 2023

chrischdi left a comment •

edited

Loading

🌱 Add unit test cases for clustermodule #2436

🌱 Add unit test cases for clustermodule #2436

Conversation

MrDXY commented Oct 16, 2023

k8s-ci-robot commented Oct 16, 2023

zhanggbj commented Oct 16, 2023

codecov bot commented Oct 16, 2023 • edited Loading

Codecov Report

chrischdi left a comment

Choose a reason for hiding this comment

MrDXY commented Oct 20, 2023

MrDXY commented Oct 24, 2023

chrischdi commented Oct 24, 2023

MrDXY commented Oct 25, 2023

MrDXY commented Oct 25, 2023

chrischdi left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 25, 2023

chrischdi left a comment

Choose a reason for hiding this comment

killianmuldoon left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 26, 2023

k8s-ci-robot commented Oct 26, 2023

chrischdi left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 16, 2023 •

edited

Loading

chrischdi left a comment •

edited

Loading