Merge pull request #2878 from chrischdi/pr-not-fail-release-notes

🌱 github: still create a draft release on release notes generation failures
kubernetes-sigs · Apr 4, 2024 · fba8e05 · fba8e05
2 parents 68e7c45 + 874ee2e
commit fba8e05
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -30,8 +30,10 @@ jobs:
         run: |
           make release
       - name: generate release notes
+        # Ignore failures for release-notes generation so they could still get
+        # generated manually before publishing.
         run: |
-          make generate-release-notes
+          make generate-release-notes || echo "Failed to generate release notes" >> _releasenotes/${{ env.RELEASE_TAG }}.md
         env:
           GH_TOKEN: ${{ github.token }}
       - name: Release