Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker version issue. #270

Conversation

morvencao
Copy link

@morvencao morvencao commented Mar 22, 2019

What this PR does / why we need it:

In ubuntu, the latest docker version(18.09) is incompatible with kubeadm, resulting user-data executing failure. See: kubernetes/minikube#3323

/cc @gyliu513 @xunpan

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: morvencao
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: timothysc

If they are not already assigned, you can assign the PR to them by writing /assign @timothysc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @morvencao. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2019
@gyliu513
Copy link
Contributor

/ok-to-test
/lgtm

FYI @jichenjc

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2019
@jichenjc
Copy link
Contributor

ok, seems reasonable ,thanks for sharing~

@chrigl
Copy link

chrigl commented Mar 26, 2019

Is this a thing any more? I am able to create new machines with Ubuntu 16.04 and 18.04. Both come up with the latest docker version.

openstack-node-test2     Ready    <none>   11s     v1.13.5   10.0.0.13     <none>            Ubuntu 16.04.3 LTS   4.4.0-112-generic   docker://18.9.2
openstack-node-test3     Ready    <none>   3m23s   v1.13.5   10.0.0.18     <none>            Ubuntu 18.04.2 LTS   4.15.0-45-generic   docker://18.9.2

@jichenjc
Copy link
Contributor

I actually hit some issue yesterday on 18.04 , it tells me docker version doesn't not support 18.09
so I guess last 24 hours some fix got upstreamed and kubeadm is updated..

@jichenjc
Copy link
Contributor

I can try tomorrow again and see whether same issue still there

@gyliu513
Copy link
Contributor

@morvencao Can you try latest build? @jichenjc has upgraded Kubernetes to 1.14.0 and it should works.

@morvencao
Copy link
Author

@gyliu513 Thanks, let me give it a try.

@gyliu513
Copy link
Contributor

/lgtm cancel

@morvencao please close this one if installation goes well.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2019
@morvencao morvencao closed this Apr 20, 2019
@morvencao morvencao deleted the br_fix_docker_version_issue branch April 20, 2019 13:58
@gyliu513
Copy link
Contributor

@morvencao so the latest user-data works?

@morvencao
Copy link
Author

Got timeout from clusterctl log, but I could manually execute the latest user-data on the provisioned machine.

It doesn't look like docker version issue now.

BTW, the version of provisioned cluster is v1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants